* [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer
@ 2022-11-21 10:17 Wang Yufen
2022-11-21 11:57 ` Tommaso Merciai
0 siblings, 1 reply; 2+ messages in thread
From: Wang Yufen @ 2022-11-21 10:17 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, sumit.semwal, christian.koenig
Cc: vkoul, linux-arm-msm, linux-i2c, linux-kernel, linux-media,
dri-devel, linaro-mm-sig, Wang Yufen
Fix to return a negative error code from the gi2c->err instead of
0.
Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/i2c/busses/i2c-qcom-geni.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index 84a7751..8fce98b 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i
dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",
gi2c->cur->flags, gi2c->cur->addr);
gi2c->err = -ETIMEDOUT;
- goto err;
}
if (gi2c->err) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer
2022-11-21 10:17 [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer Wang Yufen
@ 2022-11-21 11:57 ` Tommaso Merciai
0 siblings, 0 replies; 2+ messages in thread
From: Tommaso Merciai @ 2022-11-21 11:57 UTC (permalink / raw)
To: Wang Yufen
Cc: agross, andersson, konrad.dybcio, sumit.semwal, christian.koenig,
vkoul, linux-arm-msm, linux-i2c, linux-kernel, linux-media,
dri-devel, linaro-mm-sig
Hi Wang,
On Mon, Nov 21, 2022 at 06:17:52PM +0800, Wang Yufen wrote:
> Fix to return a negative error code from the gi2c->err instead of
> 0.
>
> Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 84a7751..8fce98b 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i
> dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",
> gi2c->cur->flags, gi2c->cur->addr);
> gi2c->err = -ETIMEDOUT;
> - goto err;
Looks good to me.
Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasoluitons.com>
Regards,
Tommaso
> }
>
> if (gi2c->err) {
> --
> 1.8.3.1
>
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 10:17 [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer Wang Yufen
2022-11-21 11:57 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®