mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Chang S. Bae" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Chang S. Bae" <chang.seok.bae@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/fpu] x86/fpu/xstate: Simplify print_xstate_features()
Date: Thu, 27 Feb 2025 19:04:37 -0000	[thread overview]
Message-ID: <174068307835.10177.5760172564992178850.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250227184502.10288-2-chang.seok.bae@intel.com>

The following commit has been merged into the x86/fpu branch of tip:

Commit-ID:     69a2fdf446049ae31be4a14a0cf16f2f18f09b6c
Gitweb:        https://git.kernel.org/tip/69a2fdf446049ae31be4a14a0cf16f2f18f09b6c
Author:        Chang S. Bae <chang.seok.bae@intel.com>
AuthorDate:    Thu, 27 Feb 2025 10:44:46 -08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 27 Feb 2025 19:54:41 +01:00

x86/fpu/xstate: Simplify print_xstate_features()

print_xstate_features() currently invokes print_xstate_feature() multiple
times on separate lines, which can be simplified in a loop.

print_xstate_feature() already checks the feature's enabled status and is
only called within print_xstate_features(). Inline print_xstate_feature()
and iterate over features in a loop to streamline the enabling message.

No functional changes.

Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lore.kernel.org/r/20250227184502.10288-2-chang.seok.bae@intel.com
---
 arch/x86/kernel/fpu/xstate.c | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 27417b6..6a41d16 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -259,32 +259,20 @@ static void __init setup_xstate_cache(void)
 	}
 }
 
-static void __init print_xstate_feature(u64 xstate_mask)
-{
-	const char *feature_name;
-
-	if (cpu_has_xfeatures(xstate_mask, &feature_name))
-		pr_info("x86/fpu: Supporting XSAVE feature 0x%03Lx: '%s'\n", xstate_mask, feature_name);
-}
-
 /*
  * Print out all the supported xstate features:
  */
 static void __init print_xstate_features(void)
 {
-	print_xstate_feature(XFEATURE_MASK_FP);
-	print_xstate_feature(XFEATURE_MASK_SSE);
-	print_xstate_feature(XFEATURE_MASK_YMM);
-	print_xstate_feature(XFEATURE_MASK_BNDREGS);
-	print_xstate_feature(XFEATURE_MASK_BNDCSR);
-	print_xstate_feature(XFEATURE_MASK_OPMASK);
-	print_xstate_feature(XFEATURE_MASK_ZMM_Hi256);
-	print_xstate_feature(XFEATURE_MASK_Hi16_ZMM);
-	print_xstate_feature(XFEATURE_MASK_PKRU);
-	print_xstate_feature(XFEATURE_MASK_PASID);
-	print_xstate_feature(XFEATURE_MASK_CET_USER);
-	print_xstate_feature(XFEATURE_MASK_XTILE_CFG);
-	print_xstate_feature(XFEATURE_MASK_XTILE_DATA);
+	int i;
+
+	for (i = 0; i < XFEATURE_MAX; i++) {
+		u64 mask = BIT_ULL(i);
+		const char *name;
+
+		if (cpu_has_xfeatures(mask, &name))
+			pr_info("x86/fpu: Supporting XSAVE feature 0x%03Lx: '%s'\n", mask, name);
+	}
 }
 
 /*

  parent reply	other threads:[~2025-02-27 19:04 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 18:44 [PATCH RFC v1 00/11] x86: Support Intel Advanced Performance Extensions Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify print_xstate_features() Chang S. Bae
2025-02-27 18:51   ` Dave Hansen
2025-02-27 18:52   ` Ingo Molnar
2025-02-27 19:04   ` tip-bot2 for Chang S. Bae [this message]
2025-02-27 18:44 ` [PATCH RFC v1 02/11] x86/fpu/xstate: Introduce xstate order table and accessor macro Chang S. Bae
2025-02-27 19:03   ` Dave Hansen
2025-02-27 19:34     ` Andrew Cooper
2025-02-27 19:42       ` Ingo Molnar
2025-03-20 23:46     ` Chang S. Bae
2025-02-27 19:05   ` Ingo Molnar
2025-02-27 19:32     ` Dave Hansen
2025-02-27 19:36       ` Ingo Molnar
2025-02-27 19:49         ` Andrew Cooper
2025-02-27 20:06           ` Ingo Molnar
2025-02-27 21:10             ` Andrew Cooper
2025-02-27 21:28               ` Ingo Molnar
2025-02-27 21:30                 ` Ingo Molnar
2025-02-27 22:23                   ` Andrew Cooper
2025-02-28  3:10                   ` Chang S. Bae
2025-02-28 17:11                     ` Ingo Molnar
2025-02-27 19:56         ` Dave Hansen
2025-02-27 20:02           ` Ingo Molnar
2025-02-27 20:19             ` Dave Hansen
2025-02-27 20:29               ` Ingo Molnar
2025-02-27 21:17                 ` Dave Hansen
2025-02-27 21:37                   ` Ingo Molnar
2025-02-27 23:54                     ` Dave Hansen
2025-02-28 15:20                       ` Sean Christopherson
2025-02-27 18:44 ` [PATCH RFC v1 03/11] x86/fpu/xstate: Remove xstate offset check Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 04/11] x86/fpu/xstate: Adjust XSAVE buffer size calculation Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 05/11] x86/fpu/xstate: Adjust xstate copying logic for user ABI Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 06/11] x86/fpu/mpx: Remove MPX xstate component support Chang S. Bae
2025-02-27 19:12   ` Ingo Molnar
2025-02-28  3:12     ` Chang S. Bae
2025-03-20 23:47       ` Chang S. Bae
2025-04-01 17:13         ` Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 07/11] x86/cpufeatures: Add X86_FEATURE_APX Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 08/11] x86/fpu/apx: Define APX state component Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 09/11] x86/fpu/apx: Disallow conflicting MPX presence Chang S. Bae
2025-02-27 23:16   ` Dave Hansen
2025-02-27 23:58     ` Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 10/11] x86/fpu/apx: Enable APX state support Chang S. Bae
2025-02-27 18:44 ` [PATCH RFC v1 11/11] selftests/x86/apx: Add APX test Chang S. Bae
2025-02-27 19:15 ` [PATCH RFC v1 00/11] x86: Support Intel Advanced Performance Extensions Ingo Molnar
2025-02-27 19:36   ` Dave Hansen
2025-02-28  3:10     ` Chang S. Bae
2025-03-20 23:42 ` [PATCH RFC v2 0/9] " Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 1/9] x86/fpu/xstate: Remove xstate offset check Chang S. Bae
2025-03-25 10:18     ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-14  7:34     ` [tip: x86/merge] " tip-bot2 for Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 2/9] x86/fpu/xstate: Introduce xfeature order table and accessor macro Chang S. Bae
2025-03-25 10:18     ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-14  7:34     ` [tip: x86/merge] " tip-bot2 for Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 3/9] x86/fpu/xstate: Adjust XSAVE buffer size calculation Chang S. Bae
2025-03-25 10:28     ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-14  7:34     ` [tip: x86/merge] " tip-bot2 for Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 4/9] x86/fpu/xstate: Adjust xstate copying logic for user ABI Chang S. Bae
2025-03-25 10:18     ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-03-25 10:28     ` tip-bot2 for Chang S. Bae
2025-04-14  7:34     ` [tip: x86/merge] " tip-bot2 for Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 5/9] x86/cpufeatures: Add X86_FEATURE_APX Chang S. Bae
2025-04-11 16:12     ` [PATCH RFC v2a " Chang S. Bae
2025-04-11 16:54       ` Sohil Mehta
2025-04-11 18:23         ` Chang S. Bae
2025-04-11 21:57           ` Sohil Mehta
2025-04-12  8:43             ` Ingo Molnar
2025-04-14  8:23               ` Ingo Molnar
2025-04-14 17:28                 ` Sohil Mehta
2025-04-14 17:32                   ` Dave Hansen
2025-04-14 17:45                     ` Sohil Mehta
2025-04-14 18:02                       ` Chang S. Bae
2025-04-14 18:12                         ` Sohil Mehta
2025-04-14 18:31                 ` Chang S. Bae
2025-04-16  2:16               ` [PATCH 00/10] x86/fpu: APX enablement and assorted FPU code improvements Chang S. Bae
2025-04-16  2:16                 ` [PATCH 01/10] x86/cpufeatures: Add X86_FEATURE_APX Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 02/10] x86/fpu/apx: Define APX state component Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 03/10] x86/fpu/apx: Disallow conflicting MPX presence Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 04/10] x86/fpu/apx: Enable APX state support Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 05/10] selftests/x86/apx: Add APX test Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 06/10] x86/fpu: Log XSAVE disablement consistently Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16 16:56                   ` [PATCH 06/10] " Sohil Mehta
2025-04-16 17:03                     ` Chang S. Bae
2025-04-16 18:04                       ` Sohil Mehta
2025-04-16  2:16                 ` [PATCH 07/10] x86/fpu: Refactor xfeature bitmask update code for sigframe XSAVE Chang S. Bae
2025-04-16  8:05                   ` Ingo Molnar
2025-04-16 16:55                     ` Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 08/10] x86/pkeys: Simplify PKRU update in signal frame Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:16                 ` [PATCH 09/10] x86/fpu: Remove export of mxcsr_feature_mask Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  2:17                 ` [PATCH 10/10] x86/fpu: Rename fpu_reset_fpregs() to fpu_reset_fpstate_regs() Chang S. Bae
2025-04-16  8:17                   ` [tip: x86/fpu] " tip-bot2 for Chang S. Bae
2025-04-16  8:07                 ` [PATCH 00/10] x86/fpu: APX enablement and assorted FPU code improvements Ingo Molnar
2025-04-16 16:56                   ` Chang S. Bae
2025-03-20 23:42   ` [PATCH RFC v2 6/9] x86/fpu/apx: Define APX state component Chang S. Bae
2025-04-11 22:54     ` Sohil Mehta
2025-03-20 23:42   ` [PATCH RFC v2 7/9] x86/fpu/apx: Disallow conflicting MPX presence Chang S. Bae
2025-04-14 17:09     ` Sohil Mehta
2025-04-14 17:25       ` Dave Hansen
2025-03-20 23:42   ` [PATCH RFC v2 8/9] x86/fpu/apx: Enable APX state support Chang S. Bae
2025-04-14 15:41     ` Sohil Mehta
2025-03-20 23:43   ` [PATCH RFC v2 9/9] selftests/x86/apx: Add APX test Chang S. Bae
2025-04-14 16:02     ` Sohil Mehta
2025-03-25 10:25   ` [PATCH RFC v2 0/9] x86: Support Intel Advanced Performance Extensions Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174068307835.10177.5760172564992178850.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®