* [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply
@ 2025-10-24 18:55 Petr Oros
2025-10-27 9:04 ` Ivan Vecera
2025-10-28 1:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Petr Oros @ 2025-10-24 18:55 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Donald Hunter, Jiri Pirko, Vadim Fedorenko,
Milena Olech, Arkadiusz Kubalewski, Petr Oros, Ivan Vecera,
Michal Michalik, open list:NETWORKING [GENERAL],
open list
Cc: mschmidt
The dpll.yaml spec incorrectly omitted module-name and clock-id from the
pin-get operation reply specification, even though the kernel DPLL
implementation has always included these attributes in pin-get responses
since the initial implementation.
This spec inconsistency caused issues with the C YNL code generator.
The generated dpll_pin_get_rsp structure was missing these fields.
Fix the spec by adding module-name and clock-id to the pin-attrs reply
specification to match the actual kernel behavior.
Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
Signed-off-by: Petr Oros <poros@redhat.com>
---
Documentation/netlink/specs/dpll.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
index cafb4ec20447e1..80728f6f9bc876 100644
--- a/Documentation/netlink/specs/dpll.yaml
+++ b/Documentation/netlink/specs/dpll.yaml
@@ -605,6 +605,8 @@ operations:
reply: &pin-attrs
attributes:
- id
+ - module-name
+ - clock-id
- board-label
- panel-label
- package-label
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply
2025-10-24 18:55 [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply Petr Oros
@ 2025-10-27 9:04 ` Ivan Vecera
2025-10-28 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ivan Vecera @ 2025-10-27 9:04 UTC (permalink / raw)
To: Petr Oros, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Donald Hunter, Jiri Pirko,
Vadim Fedorenko, Milena Olech, Arkadiusz Kubalewski,
Michal Michalik, open list:NETWORKING [GENERAL],
open list
Cc: mschmidt
On 10/24/25 8:55 PM, Petr Oros wrote:
> The dpll.yaml spec incorrectly omitted module-name and clock-id from the
> pin-get operation reply specification, even though the kernel DPLL
> implementation has always included these attributes in pin-get responses
> since the initial implementation.
>
> This spec inconsistency caused issues with the C YNL code generator.
> The generated dpll_pin_get_rsp structure was missing these fields.
>
> Fix the spec by adding module-name and clock-id to the pin-attrs reply
> specification to match the actual kernel behavior.
>
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
> Documentation/netlink/specs/dpll.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index cafb4ec20447e1..80728f6f9bc876 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -605,6 +605,8 @@ operations:
> reply: &pin-attrs
> attributes:
> - id
> + - module-name
> + - clock-id
> - board-label
> - panel-label
> - package-label
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply
2025-10-24 18:55 [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply Petr Oros
2025-10-27 9:04 ` Ivan Vecera
@ 2025-10-28 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-28 1:30 UTC (permalink / raw)
To: Petr Oros
Cc: davem, edumazet, kuba, pabeni, horms, donald.hunter, jiri,
vadim.fedorenko, milena.olech, arkadiusz.kubalewski, ivecera,
michal.michalik, netdev, linux-kernel, mschmidt
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 24 Oct 2025 20:55:12 +0200 you wrote:
> The dpll.yaml spec incorrectly omitted module-name and clock-id from the
> pin-get operation reply specification, even though the kernel DPLL
> implementation has always included these attributes in pin-get responses
> since the initial implementation.
>
> This spec inconsistency caused issues with the C YNL code generator.
> The generated dpll_pin_get_rsp structure was missing these fields.
>
> [...]
Here is the summary with links:
- [net] dpll: spec: add missing module-name and clock-id to pin-get reply
https://git.kernel.org/netdev/net/c/520ad9e96937
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-28 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-24 18:55 [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply Petr Oros
2025-10-27 9:04 ` Ivan Vecera
2025-10-28 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®