* [PATCH] block: fix aux stat accumulation destination
@ 2025-12-22 2:19 shechenglong
2025-12-25 16:44 ` Yu Kuai
0 siblings, 1 reply; 5+ messages in thread
From: shechenglong @ 2025-12-22 2:19 UTC (permalink / raw)
To: tj, josef, axboe, yukuai
Cc: cgroups, linux-block, linux-kernel, stone.xulei, chenjialong,
shechenglong
Route bfqg_stats_add_aux() time accumulation into the destination
stats object instead of the source, aligning with other stat fields.
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
block/bfq-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 9fb9f3533150..6a75fe1c7a5c 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
blkg_rwstat_add_aux(&to->merged, &from->merged);
blkg_rwstat_add_aux(&to->service_time, &from->service_time);
blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
- bfq_stat_add_aux(&from->time, &from->time);
+ bfq_stat_add_aux(&to->time, &from->time);
bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
bfq_stat_add_aux(&to->avg_queue_size_samples,
&from->avg_queue_size_samples);
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: fix aux stat accumulation destination
2025-12-22 2:19 [PATCH] block: fix aux stat accumulation destination shechenglong
@ 2025-12-25 16:44 ` Yu Kuai
2025-12-28 13:04 ` [PATCH v2 0/1] block,bfq: " shechenglong
0 siblings, 1 reply; 5+ messages in thread
From: Yu Kuai @ 2025-12-25 16:44 UTC (permalink / raw)
To: shechenglong, tj, josef, axboe
Cc: cgroups, linux-block, linux-kernel, stone.xulei, chenjialong, yukuai
Hi,
在 2025/12/22 10:19, shechenglong 写道:
> Route bfqg_stats_add_aux() time accumulation into the destination
> stats object instead of the source, aligning with other stat fields.
>
> Signed-off-by: shechenglong <shechenglong@xfusion.com>
> ---
> block/bfq-cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please change the title and follow existing prefix:
block, bfq: fix aux stat accumulation destination
Otherwise, feel free to add:
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 9fb9f3533150..6a75fe1c7a5c 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
> blkg_rwstat_add_aux(&to->merged, &from->merged);
> blkg_rwstat_add_aux(&to->service_time, &from->service_time);
> blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
> - bfq_stat_add_aux(&from->time, &from->time);
> + bfq_stat_add_aux(&to->time, &from->time);
> bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
> bfq_stat_add_aux(&to->avg_queue_size_samples,
> &from->avg_queue_size_samples);
--
Thansk,
Kuai
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 0/1] block,bfq: fix aux stat accumulation destination
2025-12-25 16:44 ` Yu Kuai
@ 2025-12-28 13:04 ` shechenglong
2025-12-28 13:04 ` [PATCH v2 1/1] " shechenglong
2025-12-28 16:07 ` [PATCH v2 0/1] " Jens Axboe
0 siblings, 2 replies; 5+ messages in thread
From: shechenglong @ 2025-12-28 13:04 UTC (permalink / raw)
To: yukuai, axboe
Cc: cgroups, chenjialong, josef, linux-block, linux-kernel,
stone.xulei, tj, shechenglong
> Please change the title and follow existing prefix:
> block, bfq: fix aux stat accumulation destination
> Otherwise, feel free to add:
> Reviewed-by: Yu Kuai <yukuai@fnnas.com>
Thanks to Yu Kuai for the review and helpful feedback.
shechenglong (1):
block,bfq: fix aux stat accumulation destination
block/bfq-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
shechenglong
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/1] block,bfq: fix aux stat accumulation destination
2025-12-28 13:04 ` [PATCH v2 0/1] block,bfq: " shechenglong
@ 2025-12-28 13:04 ` shechenglong
2025-12-28 16:07 ` [PATCH v2 0/1] " Jens Axboe
1 sibling, 0 replies; 5+ messages in thread
From: shechenglong @ 2025-12-28 13:04 UTC (permalink / raw)
To: yukuai, axboe
Cc: cgroups, chenjialong, josef, linux-block, linux-kernel,
stone.xulei, tj, shechenglong
Route bfqg_stats_add_aux() time accumulation into the destination
stats object instead of the source, aligning with other stat fields.
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
block/bfq-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 9fb9f3533150..6a75fe1c7a5c 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
blkg_rwstat_add_aux(&to->merged, &from->merged);
blkg_rwstat_add_aux(&to->service_time, &from->service_time);
blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
- bfq_stat_add_aux(&from->time, &from->time);
+ bfq_stat_add_aux(&to->time, &from->time);
bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
bfq_stat_add_aux(&to->avg_queue_size_samples,
&from->avg_queue_size_samples);
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/1] block,bfq: fix aux stat accumulation destination
2025-12-28 13:04 ` [PATCH v2 0/1] block,bfq: " shechenglong
2025-12-28 13:04 ` [PATCH v2 1/1] " shechenglong
@ 2025-12-28 16:07 ` Jens Axboe
1 sibling, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2025-12-28 16:07 UTC (permalink / raw)
To: yukuai, shechenglong
Cc: cgroups, chenjialong, josef, linux-block, linux-kernel, stone.xulei, tj
On Sun, 28 Dec 2025 21:04:25 +0800, shechenglong wrote:
> > Please change the title and follow existing prefix:
> > block, bfq: fix aux stat accumulation destination
> > Otherwise, feel free to add:
> > Reviewed-by: Yu Kuai <yukuai@fnnas.com>
>
> Thanks to Yu Kuai for the review and helpful feedback.
>
> [...]
Applied, thanks!
[1/1] block,bfq: fix aux stat accumulation destination
commit: 04bdb1a04d8a2a89df504c1e34250cd3c6e31a1c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-28 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-22 2:19 [PATCH] block: fix aux stat accumulation destination shechenglong
2025-12-25 16:44 ` Yu Kuai
2025-12-28 13:04 ` [PATCH v2 0/1] block,bfq: " shechenglong
2025-12-28 13:04 ` [PATCH v2 1/1] " shechenglong
2025-12-28 16:07 ` [PATCH v2 0/1] " Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®