mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Akash Kumar <akash.kumar@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	 Bjorn Andersson <andersson@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: usb: typec: Add Cypress CYPD6129 UCSI controller compatible
Date: Wed, 20 May 2026 06:57:39 -0500	[thread overview]
Message-ID: <177927825931.217788.5773775598155839362.robh@kernel.org> (raw)
In-Reply-To: <20260520093902.2064730-2-akash.kumar@oss.qualcomm.com>


On Wed, 20 May 2026 15:07:32 +0530, Akash Kumar wrote:
> Document the "cypress,cypd6129" compatible string for the Cypress/Infineon
> EZ-PD CCGx UCSI controller.
> 
> The CYPD6129 is compatible with the existing CCGx binding, so allow it as a
> valid compatible and permit the existing "cypress,cypd4226" fallback where
> appropriate.
> 
> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
> ---
>  .../bindings/usb/cypress,cypd4226.yaml        | 73 ++++++++++++++-----
>  1 file changed, 55 insertions(+), 18 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Lexical error: Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dts:34.31-35 Unexpected 'GPIO'
FATAL ERROR: Syntax error parsing input tree
make[2]: *** [scripts/Makefile.dtbs:140: Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1644: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260520093902.2064730-2-akash.kumar@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2026-05-20 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20  9:37 [PATCH 0/3] Add Cypress CYPD6129 UCSI support for monza SOM USB0 DRD Akash Kumar
2026-05-20  9:37 ` [PATCH 1/3] dt-bindings: usb: typec: Add Cypress CYPD6129 UCSI controller compatible Akash Kumar
2026-05-20 10:01   ` Dmitry Baryshkov
2026-05-20 10:06   ` Dmitry Baryshkov
2026-05-20 11:21   ` Krzysztof Kozlowski
2026-05-20 11:57   ` Rob Herring (Arm) [this message]
2026-05-20  9:37 ` [PATCH 2/3] arm64: dts: qcom: monaco-monza-som: Enable USB0 DRD mode Akash Kumar
2026-05-20 10:05   ` Dmitry Baryshkov
2026-05-20 10:08   ` Dmitry Baryshkov
2026-05-20 11:15   ` Konrad Dybcio
2026-05-20 11:22   ` Krzysztof Kozlowski
2026-05-20  9:37 ` [PATCH 3/3] usb: ucsi: ccg: Add support for CYPD6129 (CCG6) Akash Kumar
2026-05-20 10:07   ` Dmitry Baryshkov
2026-05-20 11:20   ` Krzysztof Kozlowski
2026-05-20 11:22 ` [PATCH 0/3] Add Cypress CYPD6129 UCSI support for monza SOM USB0 DRD Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177927825931.217788.5773775598155839362.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=akash.kumar@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®