From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akash Kumar <akash.kumar@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: ucsi: ccg: Add support for CYPD6129 (CCG6)
Date: Wed, 20 May 2026 13:20:59 +0200 [thread overview]
Message-ID: <44894052-4b29-40e2-96d7-2b1d19f7c849@kernel.org> (raw)
In-Reply-To: <20260520093902.2064730-4-akash.kumar@oss.qualcomm.com>
On 20/05/2026 11:37, Akash Kumar wrote:
> Add "cypress,cypd6129" to the UCSI CCG driver match table so the driver
> can bind to CCG6-based platforms using this controller.
>
> This is required for monza SOM USB-C support.
Pointless statement. What is "monza SOM"? Who could guess it in open
source community?
>
> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 199799b319c2..0695ce348135 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1520,6 +1520,7 @@ static void ucsi_ccg_remove(struct i2c_client *client)
>
> static const struct of_device_id ucsi_ccg_of_match_table[] = {
> { .compatible = "cypress,cypd4226", },
> + { .compatible = "cypress,cypd6129", },
NAK. You just said they are compatible!
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-20 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 9:37 [PATCH 0/3] Add Cypress CYPD6129 UCSI support for monza SOM USB0 DRD Akash Kumar
2026-05-20 9:37 ` [PATCH 1/3] dt-bindings: usb: typec: Add Cypress CYPD6129 UCSI controller compatible Akash Kumar
2026-05-20 10:01 ` Dmitry Baryshkov
2026-05-20 10:06 ` Dmitry Baryshkov
2026-05-20 11:21 ` Krzysztof Kozlowski
2026-05-20 11:57 ` Rob Herring (Arm)
2026-05-20 9:37 ` [PATCH 2/3] arm64: dts: qcom: monaco-monza-som: Enable USB0 DRD mode Akash Kumar
2026-05-20 10:05 ` Dmitry Baryshkov
2026-05-20 10:08 ` Dmitry Baryshkov
2026-05-20 11:15 ` Konrad Dybcio
2026-05-20 11:22 ` Krzysztof Kozlowski
2026-05-20 9:37 ` [PATCH 3/3] usb: ucsi: ccg: Add support for CYPD6129 (CCG6) Akash Kumar
2026-05-20 10:07 ` Dmitry Baryshkov
2026-05-20 11:20 ` Krzysztof Kozlowski [this message]
2026-05-20 11:22 ` [PATCH 0/3] Add Cypress CYPD6129 UCSI support for monza SOM USB0 DRD Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44894052-4b29-40e2-96d7-2b1d19f7c849@kernel.org \
--to=krzk@kernel.org \
--cc=akash.kumar@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®