mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Ricardo Neri" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Andrea Righi <arighi@nvidia.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings
Date: Sat, 08 Aug 2026 09:44:52 -0000	[thread overview]
Message-ID: <178618229254.442315.16915260462174352013.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260720-rneri-fix-cas-clusters-v6-1-bb500bf4afd4@linux.intel.com>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     180ff97c186971c2106e68470e4370ace0b8fbbc
Gitweb:        https://git.kernel.org/tip/180ff97c186971c2106e68470e4370ace0b8fbbc
Author:        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
AuthorDate:    Mon, 20 Jul 2026 19:43:17 -07:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 07 Aug 2026 18:27:09 +02:00

sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings

When picking a busiest CPU with only one running task, the function
sched_balance_find_src_rq() skips candidate CPUs if the destination CPU has
less than ~5% extra capacity. This condition only holds if all the SMT
siblings of a CPU are idle.

SMT siblings share the computing resources of a physical core and this
results in reduced capacity if more than one sibling is busy.

Skipping a CPU as described would prevent the load balancer from pulling
tasks from a scheduling group previously and correctly identified as
group_smt_balance (i.e., one with more than one task running).

Do not skip a candidate CPU of similar capacity if it has busy SMT
siblings.

Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Tested-by: Andrea Righi <arighi@nvidia.com>
Link: https://patch.msgid.link/20260720-rneri-fix-cas-clusters-v6-1-bb500bf4afd4@linux.intel.com
---
 kernel/sched/fair.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a24dd20..974e091 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -13086,9 +13086,17 @@ static struct rq *sched_balance_find_src_rq(struct lb_env *env,
 		 * average load.
 		 */
 		if (env->sd->flags & SD_ASYM_CPUCAPACITY &&
-		    !capacity_greater(capacity_of(env->dst_cpu), capacity) &&
-		    nr_running == 1)
-			continue;
+		    nr_running == 1) {
+			bool smt_degraded_cap = sched_smt_active() && !is_core_idle(i);
+
+			/*
+			 * Busy SMT siblings reduce the capacity of CPU @i. Do
+			 * not skip it in this case.
+			 */
+			if (!smt_degraded_cap &&
+			    !capacity_greater(capacity_of(env->dst_cpu), capacity))
+				continue;
+		}
 
 		/*
 		 * Make sure we only pull tasks from a CPU of lower priority

  reply	other threads:[~2026-08-08  9:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  2:43 [PATCH v6 0/6] sched: Fix cluster scheduling in the presence of asymmetric capacity Ricardo Neri
2026-07-21  2:43 ` [PATCH v6 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings Ricardo Neri
2026-08-08  9:44   ` tip-bot2 for Ricardo Neri [this message]
2026-07-21  2:43 ` [PATCH v6 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Ricardo Neri
2026-08-08  9:44   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2026-07-21  2:43 ` [PATCH v6 3/6] sched/fair: Check CPU capacity before comparing group types during load balance Ricardo Neri
2026-08-08  9:44   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2026-07-21  2:43 ` [PATCH v6 4/6] sched/fair: Skip misfit load accounting when the destination CPU cannot help Ricardo Neri
2026-08-08  9:44   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2026-07-21  2:43 ` [PATCH v6 5/6] sched/fair: Allow load balancing between CPUs of identical capacity Ricardo Neri
2026-07-23  7:10   ` Christian Loehle
2026-08-04  9:55     ` Vincent Guittot
2026-08-06  3:34       ` Ricardo Neri
2026-08-04  9:50   ` Vincent Guittot
2026-08-08  9:44   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2026-07-21  2:43 ` [PATCH v6 6/6] sched/topology: Restore SD_PREFER_SIBLING in domains with asymmetric capacity Ricardo Neri
2026-08-04  9:56   ` Vincent Guittot
2026-08-08  9:44   ` [tip: sched/core] " tip-bot2 for Ricardo Neri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178618229254.442315.16915260462174352013.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=arighi@nvidia.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®