mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	"Jagadeesh Kona" <quic_jkona@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm8150: Add video clock controller node
Date: Thu, 14 Mar 2024 14:43:41 +0530	[thread overview]
Message-ID: <1a2a7d7d-ed67-1c90-d3d1-4529dc07effa@quicinc.com> (raw)
In-Reply-To: <CAA8EJprrrSTLBoLGMSJw3g9BEcL6y+To1tr65b+AzNz01MgjTg@mail.gmail.com>


On 3/14/2024 12:46 AM, Dmitry Baryshkov wrote:
> On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> Add device node for video clock controller on Qualcomm
>> SM8150 platform.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8155p.dtsi |  4 ++++
>>   arch/arm64/boot/dts/qcom/sm8150.dtsi  | 13 +++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8155p.dtsi b/arch/arm64/boot/dts/qcom/sa8155p.dtsi
>> index ffb7ab695213..9e70effc72e1 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8155p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8155p.dtsi
>> @@ -38,3 +38,7 @@ &rpmhpd {
>>           */
>>          compatible = "qcom,sa8155p-rpmhpd";
>>   };
>> +
>> +&videocc {
>> +       power-domains = <&rpmhpd SA8155P_CX>;
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index a35c0852b5a1..6573c907d7e2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -14,6 +14,7 @@
>>   #include <dt-bindings/clock/qcom,dispcc-sm8150.h>
>>   #include <dt-bindings/clock/qcom,gcc-sm8150.h>
>>   #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>   #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>   #include <dt-bindings/interconnect/qcom,sm8150.h>
>>   #include <dt-bindings/thermal/thermal.h>
>> @@ -3715,6 +3716,18 @@ usb_2_dwc3: usb@a800000 {
>>                          };
>>                  };
>>
>> +               videocc: clock-controller@ab00000 {
>> +                       compatible = "qcom,sm8150-videocc";
>> +                       reg = <0 0x0ab00000 0 0x10000>;
>> +                       clocks = <&rpmhcc RPMH_CXO_CLK>,
>> +                                <&gcc GCC_VIDEO_AHB_CLK>;
>> +                       power-domains = <&rpmhpd SM8150_MMCX>;
>> +                       required-opps = <&rpmhpd_opp_low_svs>;
> Should not be necessary anymore.


Whenever the rail is turned on, we want to keep it in low_svs state 
instead of retention, hence added this property , please let me know why 
you think it is not needed?


>> +                       #clock-cells = <1>;
>> +                       #reset-cells = <1>;
>> +                       #power-domain-cells = <1>;
>> +               };
>> +
>>                  camnoc_virt: interconnect@ac00000 {
>>                          compatible = "qcom,sm8150-camnoc-virt";
>>                          reg = <0 0x0ac00000 0 0x1000>;
>>
>> --
>> 2.25.1
>>
>>
>

  reply	other threads:[~2024-03-14  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 11:08 [PATCH 0/3] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-03-13 11:08 ` [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings Satya Priya Kakitapalli
2024-03-13 16:51   ` Krzysztof Kozlowski
2024-03-14  9:13     ` Satya Priya Kakitapalli (Temp)
2024-03-14 10:15       ` Krzysztof Kozlowski
2024-03-13 19:20   ` Dmitry Baryshkov
2024-03-14  9:19     ` Satya Priya Kakitapalli (Temp)
2024-03-14 13:05       ` Dmitry Baryshkov
2024-03-13 11:08 ` [PATCH 2/3] clk: qcom: videocc-sm8150: Add index based clk lookup Satya Priya Kakitapalli
2024-03-13 19:18   ` Dmitry Baryshkov
2024-03-14  9:14     ` Satya Priya Kakitapalli (Temp)
2024-03-13 11:08 ` [PATCH 3/3] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
2024-03-13 19:16   ` Dmitry Baryshkov
2024-03-14  9:13     ` Satya Priya Kakitapalli (Temp) [this message]
2024-03-14 12:50       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a2a7d7d-ed67-1c90-d3d1-4529dc07effa@quicinc.com \
    --to=quic_skakitap@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®