From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
"Jagadeesh Kona" <quic_jkona@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 2/3] clk: qcom: videocc-sm8150: Add index based clk lookup
Date: Thu, 14 Mar 2024 14:44:20 +0530 [thread overview]
Message-ID: <d5f9ff11-ebef-44e6-8f4c-d0a2beed1f8e@quicinc.com> (raw)
In-Reply-To: <CAA8EJpqsQr2nfDbW1JRyBoNSemudgrpxCRYH1y0ayX2Wd2u=VQ@mail.gmail.com>
On 3/14/2024 12:48 AM, Dmitry Baryshkov wrote:
> On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> Add support to look up for clocks using index instead of fw_name.
> Why? You are breaking compatibility with existing bindings.
> Also the commit message is incorrect. You are not _adding_ support.
> You are changing name-based lookup to index-based one.
As per the recent upstream discussions, I see that the clock names is
not being allowed to use, it is recommended to use the index based
lookup. Hence I updated this before adding the DT node.
Will update the commit text accordingly.
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> drivers/clk/qcom/videocc-sm8150.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/videocc-sm8150.c b/drivers/clk/qcom/videocc-sm8150.c
>> index a0329260157a..2b788a03c5ed 100644
>> --- a/drivers/clk/qcom/videocc-sm8150.c
>> +++ b/drivers/clk/qcom/videocc-sm8150.c
>> @@ -19,6 +19,10 @@
>> #include "reset.h"
>> #include "gdsc.h"
>>
>> +enum {
>> + DT_BI_TCXO,
>> +};
>> +
>> enum {
>> P_BI_TCXO,
>> P_VIDEO_PLL0_OUT_MAIN,
>> @@ -49,7 +53,7 @@ static struct clk_alpha_pll video_pll0 = {
>> .hw.init = &(struct clk_init_data){
>> .name = "video_pll0",
>> .parent_data = &(const struct clk_parent_data){
>> - .fw_name = "bi_tcxo",
>> + .index = DT_BI_TCXO,
>> },
>> .num_parents = 1,
>> .ops = &clk_alpha_pll_trion_ops,
>> @@ -63,7 +67,7 @@ static const struct parent_map video_cc_parent_map_0[] = {
>> };
>>
>> static const struct clk_parent_data video_cc_parent_data_0[] = {
>> - { .fw_name = "bi_tcxo" },
>> + { .index = DT_BI_TCXO },
>> { .hw = &video_pll0.clkr.hw },
>> };
>>
>>
>> --
>> 2.25.1
>>
>>
>
next prev parent reply other threads:[~2024-03-14 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 11:08 [PATCH 0/3] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-03-13 11:08 ` [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings Satya Priya Kakitapalli
2024-03-13 16:51 ` Krzysztof Kozlowski
2024-03-14 9:13 ` Satya Priya Kakitapalli (Temp)
2024-03-14 10:15 ` Krzysztof Kozlowski
2024-03-13 19:20 ` Dmitry Baryshkov
2024-03-14 9:19 ` Satya Priya Kakitapalli (Temp)
2024-03-14 13:05 ` Dmitry Baryshkov
2024-03-13 11:08 ` [PATCH 2/3] clk: qcom: videocc-sm8150: Add index based clk lookup Satya Priya Kakitapalli
2024-03-13 19:18 ` Dmitry Baryshkov
2024-03-14 9:14 ` Satya Priya Kakitapalli (Temp) [this message]
2024-03-13 11:08 ` [PATCH 3/3] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
2024-03-13 19:16 ` Dmitry Baryshkov
2024-03-14 9:13 ` Satya Priya Kakitapalli (Temp)
2024-03-14 12:50 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5f9ff11-ebef-44e6-8f4c-d0a2beed1f8e@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®