From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings
Date: Thu, 14 Mar 2024 11:15:05 +0100 [thread overview]
Message-ID: <c6a97c53-3220-413d-bc48-f23119c86ce3@linaro.org> (raw)
In-Reply-To: <a69f6dda-f488-a1be-803d-258fb8c6cb7b@quicinc.com>
On 14/03/2024 10:13, Satya Priya Kakitapalli (Temp) wrote:
>
> On 3/13/2024 10:21 PM, Krzysztof Kozlowski wrote:
>> On 13/03/2024 12:08, Satya Priya Kakitapalli wrote:
>>> Update the videocc device tree bindings for sm8150 to align with the
>>> latest convention.
>> Everything is an update. Please explain what you did and why. The "why"
>> part you tried to cover but I just don't understand what is "align with
>> the latest convention". What convention?
>
>
> As per the recent upstream discussions, it is recommended to use
> index-based lookup instead of using clock names. The current bindings is
> not aligned with this, hence updating. I'll add the details to commit text.
Yes, please.
>
>
>>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
>> What is the bug being fixed here?
>
>
> There are 2 clocks required for this, AHB and XO. Only one clock is
> mentioned in the bindings for SM8150, this is one of the reasons to move
> to latest sm8450 bindings apart from clock names. Hence added a Fixes tag.
This should be in the commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-14 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 11:08 [PATCH 0/3] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-03-13 11:08 ` [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings Satya Priya Kakitapalli
2024-03-13 16:51 ` Krzysztof Kozlowski
2024-03-14 9:13 ` Satya Priya Kakitapalli (Temp)
2024-03-14 10:15 ` Krzysztof Kozlowski [this message]
2024-03-13 19:20 ` Dmitry Baryshkov
2024-03-14 9:19 ` Satya Priya Kakitapalli (Temp)
2024-03-14 13:05 ` Dmitry Baryshkov
2024-03-13 11:08 ` [PATCH 2/3] clk: qcom: videocc-sm8150: Add index based clk lookup Satya Priya Kakitapalli
2024-03-13 19:18 ` Dmitry Baryshkov
2024-03-14 9:14 ` Satya Priya Kakitapalli (Temp)
2024-03-13 11:08 ` [PATCH 3/3] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
2024-03-13 19:16 ` Dmitry Baryshkov
2024-03-14 9:13 ` Satya Priya Kakitapalli (Temp)
2024-03-14 12:50 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a97c53-3220-413d-bc48-f23119c86ce3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®