mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	"Jagadeesh Kona" <quic_jkona@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings
Date: Thu, 14 Mar 2024 14:49:37 +0530	[thread overview]
Message-ID: <a09941ff-7b43-a964-1bd1-5321913be1a3@quicinc.com> (raw)
In-Reply-To: <CAA8EJpo63oRA07QNCdzJdHW_hJJWK6aj-LCpp-XwmPJYf0twZw@mail.gmail.com>


On 3/14/2024 12:50 AM, Dmitry Baryshkov wrote:
> On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> Update the videocc device tree bindings for sm8150 to align with the
>> latest convention.
> But why? Bindings already exist. There is nothing wrong with them. And
> sm8150 platform in general uses name-based lookup.


With the new index based lookup introduced we cannot use this bindings, 
hence I moved to the sm8450-videocc bindings.


>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> It is not a fix, there is no bug that this commit is fixing.


The clocks list needs to be fixed to add both XO and AHB clocks, and we 
are adding required-opps property.


>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 +
>>   Documentation/devicetree/bindings/clock/qcom,videocc.yaml        | 3 ---
>>   2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> index bad8f019a8d3..e00fdc8ceaa4 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> @@ -20,6 +20,7 @@ properties:
>>       enum:
>>         - qcom,sm8450-videocc
>>         - qcom,sm8550-videocc
>> +      - qcom,sm8150-videocc
>>
>>     reg:
>>       maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> index 6999e36ace1b..28d134ad9517 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> @@ -17,7 +17,6 @@ description: |
>>       include/dt-bindings/clock/qcom,videocc-sc7180.h
>>       include/dt-bindings/clock/qcom,videocc-sc7280.h
>>       include/dt-bindings/clock/qcom,videocc-sdm845.h
>> -    include/dt-bindings/clock/qcom,videocc-sm8150.h
>>       include/dt-bindings/clock/qcom,videocc-sm8250.h
>>
>>   properties:
>> @@ -26,7 +25,6 @@ properties:
>>         - qcom,sc7180-videocc
>>         - qcom,sc7280-videocc
>>         - qcom,sdm845-videocc
>> -      - qcom,sm8150-videocc
>>         - qcom,sm8250-videocc
>>
>>     clocks:
>> @@ -75,7 +73,6 @@ allOf:
>>             enum:
>>               - qcom,sc7180-videocc
>>               - qcom,sdm845-videocc
>> -            - qcom,sm8150-videocc
>>       then:
>>         properties:
>>           clocks:
>>
>> --
>> 2.25.1
>>
>>
>

  reply	other threads:[~2024-03-14  9:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 11:08 [PATCH 0/3] Add DT support for video clock controller on SM8150 Satya Priya Kakitapalli
2024-03-13 11:08 ` [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings Satya Priya Kakitapalli
2024-03-13 16:51   ` Krzysztof Kozlowski
2024-03-14  9:13     ` Satya Priya Kakitapalli (Temp)
2024-03-14 10:15       ` Krzysztof Kozlowski
2024-03-13 19:20   ` Dmitry Baryshkov
2024-03-14  9:19     ` Satya Priya Kakitapalli (Temp) [this message]
2024-03-14 13:05       ` Dmitry Baryshkov
2024-03-13 11:08 ` [PATCH 2/3] clk: qcom: videocc-sm8150: Add index based clk lookup Satya Priya Kakitapalli
2024-03-13 19:18   ` Dmitry Baryshkov
2024-03-14  9:14     ` Satya Priya Kakitapalli (Temp)
2024-03-13 11:08 ` [PATCH 3/3] arm64: dts: qcom: sm8150: Add video clock controller node Satya Priya Kakitapalli
2024-03-13 19:16   ` Dmitry Baryshkov
2024-03-14  9:13     ` Satya Priya Kakitapalli (Temp)
2024-03-14 12:50       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a09941ff-7b43-a964-1bd1-5321913be1a3@quicinc.com \
    --to=quic_skakitap@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®