* [PATCH v3 1/4] arm64: dts: k3-am62a-main: Add C7xv device node
2024-06-05 12:48 [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
@ 2024-06-05 12:48 ` Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 2/4] arm64: dts: k3-am62a-mcu: Add R5F remote proc node Hari Nagalla
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Hari Nagalla @ 2024-06-05 12:48 UTC (permalink / raw)
To: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
From: Jai Luthra <j-luthra@ti.com>
AM62A SoCs have a C7xv DSP subsystem with Analytics engine capability.
This subsystem is intended for deep learning purposes. Define the
device node for C7xv DSP.
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index bf9c2d9c6439..0912cc31329c 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -1062,4 +1062,15 @@ vpu: video-codec@30210000 {
clocks = <&k3_clks 204 2>;
power-domains = <&k3_pds 204 TI_SCI_PD_EXCLUSIVE>;
};
+
+ c7x_0: dsp@7e000000 {
+ compatible = "ti,am62a-c7xv-dsp";
+ reg = <0x00 0x7e000000 0x00 0x00100000>;
+ reg-names = "l2sram";
+ ti,sci = <&dmsc>;
+ ti,sci-dev-id = <208>;
+ ti,sci-proc-ids = <0x04 0xff>;
+ resets = <&k3_reset 208 1>;
+ firmware-name = "am62a-c71_0-fw";
+ };
};
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 2/4] arm64: dts: k3-am62a-mcu: Add R5F remote proc node
2024-06-05 12:48 [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 1/4] arm64: dts: k3-am62a-main: Add C7xv device node Hari Nagalla
@ 2024-06-05 12:48 ` Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node Hari Nagalla
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Hari Nagalla @ 2024-06-05 12:48 UTC (permalink / raw)
To: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
AM62A SoCs have a single R5F core in the MCU voltage domain. The MCU
domain also has a 512KB sram memory, the R5F core can use for
applications needing fast memory access.
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 35 ++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
index 8c36e56f4138..803da3cce336 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi
@@ -6,6 +6,17 @@
*/
&cbass_mcu {
+ mcu_ram: sram@79100000 {
+ compatible = "mmio-sram";
+ reg = <0x00 0x79100000 0x00 0x80000>;
+ ranges = <0x00 0x00 0x79100000 0x80000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ mcu1-sram@0 {
+ reg = <0x0 0x80000>;
+ };
+ };
mcu_pmx0: pinctrl@4084000 {
compatible = "pinctrl-single";
reg = <0x00 0x04084000 0x00 0x88>;
@@ -167,4 +178,28 @@ mcu_mcan1: can@4e18000 {
bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
status = "disabled";
};
+
+ mcu_r5fss0: r5fss@79000000 {
+ compatible = "ti,am62-r5fss";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x79000000 0x00 0x79000000 0x8000>,
+ <0x79020000 0x00 0x79020000 0x8000>;
+ power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
+ mcu_r5fss0_core0: r5f@79000000 {
+ compatible = "ti,am62-r5f";
+ reg = <0x79000000 0x00008000>,
+ <0x79020000 0x00008000>;
+ reg-names = "atcm", "btcm";
+ ti,sci = <&dmsc>;
+ ti,sci-dev-id = <9>;
+ ti,sci-proc-ids = <0x03 0xff>;
+ resets = <&k3_reset 9 1>;
+ firmware-name = "am62a-mcu-r5f0_0-fw";
+ ti,atcm-enable = <0>;
+ ti,btcm-enable = <1>;
+ ti,loczrama = <0>;
+ sram = <&mcu_ram>;
+ };
+ };
};
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node
2024-06-05 12:48 [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 1/4] arm64: dts: k3-am62a-main: Add C7xv device node Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 2/4] arm64: dts: k3-am62a-mcu: Add R5F remote proc node Hari Nagalla
@ 2024-06-05 12:48 ` Hari Nagalla
2024-06-05 12:48 ` [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes Hari Nagalla
2024-06-06 15:56 ` [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Rob Herring (Arm)
4 siblings, 0 replies; 11+ messages in thread
From: Hari Nagalla @ 2024-06-05 12:48 UTC (permalink / raw)
To: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
From: Devarsh Thakkar <devarsht@ti.com>
AM62A SoCs have a single R5F core in waekup domain. This core is also
used as a device manager for the SoC.
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
index 98043e9aa316..70471d969aa6 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
@@ -73,6 +73,29 @@ wkup_rti0: watchdog@2b000000 {
status = "reserved";
};
+ wkup_r5fss0: r5fss@78000000 {
+ compatible = "ti,am62-r5fss";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x78000000 0x00 0x78000000 0x8000>,
+ <0x78100000 0x00 0x78100000 0x8000>;
+ power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
+ wkup_r5fss0_core0: r5f@78000000 {
+ compatible = "ti,am62-r5f";
+ reg = <0x78000000 0x00008000>,
+ <0x78100000 0x00008000>;
+ reg-names = "atcm", "btcm";
+ ti,sci = <&dmsc>;
+ ti,sci-dev-id = <121>;
+ ti,sci-proc-ids = <0x01 0xff>;
+ resets = <&k3_reset 121 1>;
+ firmware-name = "am62-wkup-r5f0_0-fw";
+ ti,atcm-enable = <1>;
+ ti,btcm-enable = <1>;
+ ti,loczrama = <1>;
+ };
+ };
+
wkup_vtm0: temperature-sensor@b00000 {
compatible = "ti,j7200-vtm";
reg = <0x00 0xb00000 0x00 0x400>,
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-05 12:48 [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
` (2 preceding siblings ...)
2024-06-05 12:48 ` [PATCH v3 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node Hari Nagalla
@ 2024-06-05 12:48 ` Hari Nagalla
2024-06-06 17:16 ` Bryan Brattlof
2024-06-10 7:02 ` Vignesh Raghavendra
2024-06-06 15:56 ` [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Rob Herring (Arm)
4 siblings, 2 replies; 11+ messages in thread
From: Hari Nagalla @ 2024-06-05 12:48 UTC (permalink / raw)
To: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
From: Devarsh Thakkar <devarsht@ti.com>
Reserve memory for remote rpoc IPC and bind the mailbox assignments
for each remote proc. Two memory regions are reserved for each
remote processor. The first region of 1Mb of memory is used for Vring
shared buffers and the second region is used as external memory to the
remote processor, resource table and as tracebuffer.
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 68 +++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index fa43cd0b631e..09bb8af53b1e 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -52,11 +52,40 @@ secure_ddr: optee@9e800000 {
no-map;
};
+ wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0x9c800000 0x00 0x100000>;
+ no-map;
+ };
+
wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 {
compatible = "shared-dma-pool";
reg = <0x00 0x9c900000 0x00 0x01e00000>;
no-map;
};
+ mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@9b800000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0x9b800000 0x00 0x100000>;
+ no-map;
+ };
+
+ mcu_r5fss0_core0_memory_region: r5f-dma-memory@9b900000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0x9b900000 0x00 0x0f00000>;
+ no-map;
+ };
+
+ c7x_0_dma_memory_region: c7x-dma-memory@99800000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0x99800000 0x00 0x100000>;
+ no-map;
+ };
+
+ c7x_0_memory_region: c7x-memory@99900000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0x99900000 0x00 0x01efffff>;
+ no-map;
+ };
};
vmain_pd: regulator-0 {
@@ -721,3 +750,42 @@ dpi1_out: endpoint {
};
};
};
+
+&mailbox0_cluster0 {
+ mbox_r5_0: mbox-r5-0 {
+ ti,mbox-rx = <0 0 0>;
+ ti,mbox-tx = <1 0 0>;
+ };
+};
+
+&mailbox0_cluster1 {
+ mbox_c7x_0: mbox-c7x-0 {
+ ti,mbox-rx = <0 0 0>;
+ ti,mbox-tx = <1 0 0>;
+ };
+};
+
+&mailbox0_cluster2 {
+ mbox_mcu_r5_0: mbox-mcu-r5-0 {
+ ti,mbox-rx = <0 0 0>;
+ ti,mbox-tx = <1 0 0>;
+ };
+};
+
+&c7x_0 {
+ mboxes = <&mailbox0_cluster1>, <&mbox_c7x_0>;
+ memory-region = <&c7x_0_dma_memory_region>,
+ <&c7x_0_memory_region>;
+};
+
+&wkup_r5fss0_core0 {
+ mboxes = <&mailbox0_cluster0>, <&mbox_r5_0>;
+ memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
+ <&wkup_r5fss0_core0_memory_region>;
+};
+
+&mcu_r5fss0_core0 {
+ mboxes = <&mailbox0_cluster2>, <&mbox_mcu_r5_0>;
+ memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
+ <&mcu_r5fss0_core0_memory_region>;
+};
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-05 12:48 ` [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes Hari Nagalla
@ 2024-06-06 17:16 ` Bryan Brattlof
2024-06-10 15:52 ` Hari Nagalla
2024-06-10 7:02 ` Vignesh Raghavendra
1 sibling, 1 reply; 11+ messages in thread
From: Bryan Brattlof @ 2024-06-06 17:16 UTC (permalink / raw)
To: Hari Nagalla
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm,
linux-kernel, linux-arm-kernel, devicetree
Hi Hari,
On June 5, 2024 thus sayeth Hari Nagalla:
> From: Devarsh Thakkar <devarsht@ti.com>
>
> Reserve memory for remote rpoc IPC and bind the mailbox assignments
> for each remote proc. Two memory regions are reserved for each
> remote processor. The first region of 1Mb of memory is used for Vring
> shared buffers and the second region is used as external memory to the
> remote processor, resource table and as tracebuffer.
>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 68 +++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index fa43cd0b631e..09bb8af53b1e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -52,11 +52,40 @@ secure_ddr: optee@9e800000 {
> no-map;
> };
>
> + wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9c800000 0x00 0x100000>;
> + no-map;
> + };
> +
> wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 {
> compatible = "shared-dma-pool";
> reg = <0x00 0x9c900000 0x00 0x01e00000>;
> no-map;
> };
> + mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@9b800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9b800000 0x00 0x100000>;
> + no-map;
> + };
> +
> + mcu_r5fss0_core0_memory_region: r5f-dma-memory@9b900000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9b900000 0x00 0x0f00000>;
> + no-map;
> + };
> +
> + c7x_0_dma_memory_region: c7x-dma-memory@99800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x99800000 0x00 0x100000>;
> + no-map;
> + };
> +
> + c7x_0_memory_region: c7x-memory@99900000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x99900000 0x00 0x01efffff>;
> + no-map;
> + };
> };
This seems highly specific to the demos we're currently running for our
reference boards. If someone wants to develop their own app say with
Zypher they would instantly need to change this.
If these absolutely need to be in here could they go in a TI-demo overly?
~Bryan
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-06 17:16 ` Bryan Brattlof
@ 2024-06-10 15:52 ` Hari Nagalla
2024-06-10 19:30 ` Bryan Brattlof
0 siblings, 1 reply; 11+ messages in thread
From: Hari Nagalla @ 2024-06-10 15:52 UTC (permalink / raw)
To: Bryan Brattlof
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm,
linux-kernel, linux-arm-kernel, devicetree
On 6/6/24 12:16, Bryan Brattlof wrote:
>> +
>> + c7x_0_memory_region: c7x-memory@99900000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0x00 0x99900000 0x00 0x01efffff>;
>> + no-map;
>> + };
>> };
> This seems highly specific to the demos we're currently running for our
> reference boards. If someone wants to develop their own app say with
> Zypher they would instantly need to change this.
>
> If these absolutely need to be in here could they go in a TI-demo overly?
>
> ~Bryan
Hey Bryan,
You are correct, these carveouts match the TI provided firmware
binaries. Ideally, these could go into an overlay. Just following the
carveout model used with the rest of the TI SoCs (AM6x/J72x), to avoid
confusion to the users.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-10 15:52 ` Hari Nagalla
@ 2024-06-10 19:30 ` Bryan Brattlof
0 siblings, 0 replies; 11+ messages in thread
From: Bryan Brattlof @ 2024-06-10 19:30 UTC (permalink / raw)
To: Hari Nagalla
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm,
linux-kernel, linux-arm-kernel, devicetree
On June 10, 2024 thus sayeth Hari Nagalla:
> On 6/6/24 12:16, Bryan Brattlof wrote:
> > > +
> > > + c7x_0_memory_region: c7x-memory@99900000 {
> > > + compatible = "shared-dma-pool";
> > > + reg = <0x00 0x99900000 0x00 0x01efffff>;
> > > + no-map;
> > > + };
> > > };
> > This seems highly specific to the demos we're currently running for our
> > reference boards. If someone wants to develop their own app say with
> > Zypher they would instantly need to change this.
> >
> > If these absolutely need to be in here could they go in a TI-demo overly?
> >
> > ~Bryan
> Hey Bryan,
> You are correct, these carveouts match the TI provided firmware binaries.
> Ideally, these could go into an overlay. Just following the carveout model
> used with the rest of the TI SoCs (AM6x/J72x), to avoid confusion to the
> users.
Ah yeah, I was planning to rip those out too ;)
My idea was to throw them into our SDK layers so that other distros
don't have to work around them anymore. This also gives the maintainers
of those meta- layers the control of the reserved-memory{} node so they
can carve it up or move it around as they need along with the firmware
they build.
~Bryan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-05 12:48 ` [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes Hari Nagalla
2024-06-06 17:16 ` Bryan Brattlof
@ 2024-06-10 7:02 ` Vignesh Raghavendra
2024-06-10 15:56 ` Hari Nagalla
1 sibling, 1 reply; 11+ messages in thread
From: Vignesh Raghavendra @ 2024-06-10 7:02 UTC (permalink / raw)
To: Hari Nagalla, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
On 05/06/24 18:18, Hari Nagalla wrote:
> From: Devarsh Thakkar <devarsht@ti.com>
>
> Reserve memory for remote rpoc IPC and bind the mailbox assignments
> for each remote proc. Two memory regions are reserved for each
> remote processor. The first region of 1Mb of memory is used for Vring
s/1Mb/1MB?
> shared buffers and the second region is used as external memory to the
> remote processor, resource table and as tracebuffer.
>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 68 +++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index fa43cd0b631e..09bb8af53b1e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -52,11 +52,40 @@ secure_ddr: optee@9e800000 {
> no-map;
> };
>
> + wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9c800000 0x00 0x100000>;
> + no-map;
> + };
> +
> wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 {
> compatible = "shared-dma-pool";
> reg = <0x00 0x9c900000 0x00 0x01e00000>;
> no-map;
> };
> + mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@9b800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9b800000 0x00 0x100000>;
> + no-map;
> + };
> +
> + mcu_r5fss0_core0_memory_region: r5f-dma-memory@9b900000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9b900000 0x00 0x0f00000>;
> + no-map;
> + };
> +
> + c7x_0_dma_memory_region: c7x-dma-memory@99800000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x99800000 0x00 0x100000>;
> + no-map;
> + };
> +
> + c7x_0_memory_region: c7x-memory@99900000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x99900000 0x00 0x01efffff>;
0x01efffff -> are you sure this is correct? Just missing a byte to a
nice round number size. looks like typo of using range vs size?
> + no-map;
> + };
> };
>
> vmain_pd: regulator-0 {
> @@ -721,3 +750,42 @@ dpi1_out: endpoint {
> };
> };
> };
> +
> +&mailbox0_cluster0 {
> + mbox_r5_0: mbox-r5-0 {
> + ti,mbox-rx = <0 0 0>;
> + ti,mbox-tx = <1 0 0>;
> + };
> +};
> +
> +&mailbox0_cluster1 {
> + mbox_c7x_0: mbox-c7x-0 {
> + ti,mbox-rx = <0 0 0>;
> + ti,mbox-tx = <1 0 0>;
> + };
> +};
> +
> +&mailbox0_cluster2 {
> + mbox_mcu_r5_0: mbox-mcu-r5-0 {
> + ti,mbox-rx = <0 0 0>;
> + ti,mbox-tx = <1 0 0>;
> + };
> +};
> +
> +&c7x_0 {
> + mboxes = <&mailbox0_cluster1>, <&mbox_c7x_0>;
> + memory-region = <&c7x_0_dma_memory_region>,
> + <&c7x_0_memory_region>;
> +};
> +
> +&wkup_r5fss0_core0 {
> + mboxes = <&mailbox0_cluster0>, <&mbox_r5_0>;
> + memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
> + <&wkup_r5fss0_core0_memory_region>;
> +};
> +
> +&mcu_r5fss0_core0 {
> + mboxes = <&mailbox0_cluster2>, <&mbox_mcu_r5_0>;
> + memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
> + <&mcu_r5fss0_core0_memory_region>;
> +};
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
2024-06-10 7:02 ` Vignesh Raghavendra
@ 2024-06-10 15:56 ` Hari Nagalla
0 siblings, 0 replies; 11+ messages in thread
From: Hari Nagalla @ 2024-06-10 15:56 UTC (permalink / raw)
To: Vignesh Raghavendra, kristo, robh+dt, krzysztof.kozlowski+dt,
conor+dt, nm
Cc: linux-kernel, linux-arm-kernel, devicetree
On 6/10/24 02:02, Vignesh Raghavendra wrote:
>> Reserve memory for remote rpoc IPC and bind the mailbox assignments
>> for each remote proc. Two memory regions are reserved for each
>> remote processor. The first region of 1Mb of memory is used for Vring
> s/1Mb/1MB?
>
Yes, will correct it to 1MB.
>> + reg = <0x00 0x99900000 0x00 0x01efffff>;
> 0x01efffff -> are you sure this is correct? Just missing a byte to a
> nice round number size. looks like typo of using range vs size?
>
You are right. Will round it to 0x01f00000.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC
2024-06-05 12:48 [PATCH v3 0/4] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
` (3 preceding siblings ...)
2024-06-05 12:48 ` [PATCH v3 4/4] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes Hari Nagalla
@ 2024-06-06 15:56 ` Rob Herring (Arm)
4 siblings, 0 replies; 11+ messages in thread
From: Rob Herring (Arm) @ 2024-06-06 15:56 UTC (permalink / raw)
To: Hari Nagalla
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel,
kristo, linux-arm-kernel, conor+dt, vigneshr, nm
On Wed, 05 Jun 2024 07:48:55 -0500, Hari Nagalla wrote:
> This patch series adds R5F and C7x dsp processor nodes and shared
> memory based Virtio/IPC configuration for AM62A SoC.
>
> changes in v3:
> *) Separated DSP node binding patch and submitted to remoteproc
> mailing list, rebased the patches to linux-next.
>
> v2: https://lore.kernel.org/all/20230810005850.21998-1-hnagalla@ti.com/
>
> Devarsh Thakkar (2):
> arm64: dts: k3-am62a-wakeup: Add R5F device node
> arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes
>
> Hari Nagalla (1):
> arm64: dts: k3-am62a-mcu: Add R5F remote proc node
>
> Jai Luthra (1):
> arm64: dts: k3-am62a-main: Add C7xv device node
>
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 11 ++++
> arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 35 +++++++++++
> arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 68 +++++++++++++++++++++
> 4 files changed, 137 insertions(+)
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y ti/k3-am62a7-sk.dtb' for 20240605124859.3034-1-hnagalla@ti.com:
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: reg: [[0, 2113929216, 0, 1048576]] is too short
from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: reg-names: ['l2sram'] is too short
from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: Unevaluated properties are not allowed ('reg', 'reg-names' were unexpected)
from schema $id: http://devicetree.org/schemas/remoteproc/ti,k3-dsp-rproc.yaml#
^ permalink raw reply [flat|nested] 11+ messages in thread