mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Chris Li <sparse@chrisli.org>
Subject: Re: [PATCH v2] tracing: Make is_signed_type() compatible with sparse
Date: Tue, 1 Sep 2026 14:43:06 -0700	[thread overview]
Message-ID: <1b86ccbf-4e41-4a26-9d22-8bd93bacb043@acm.org> (raw)
In-Reply-To: <20260901222909.05d6239f@pumpkin>

On 9/1/26 2:29 PM, David Laight wrote:
> On Tue, 1 Sep 2026 11:05:18 -0700
> Bart Van Assche <bvanassche@acm.org> wrote:
> 
>> On 9/1/26 1:20 AM, David Laight wrote:
>>> I suspect you need to change the TRACE_EVENT() calls to remove the
>>> __bitwise marker.
>>
>> How to remove the __bitwise marker? Removing the __bitwise marker is not
>> supported by sparse, isn't it?
> 
> Wont (__force u32)u32_bitwise_var remove it - you just have to know the
> type.

Yes, removing __bitwise is possible if the underlying type is known. In
the context of the is_signed_type() macro, the underlying type is not
passed as an argument to that macro.

The implementation in sparse of __type_unqual__ does not remove
__attribute__((bitwise)) as far as I know. __typeof_unqual__ only strips
C type qualifiers: const, volatile, restrict, and _Atomic.

The only generic way I know of to remove the __bitwise marker is by
using _Generic(). But that approach has been rejected by Linus.

Bart.

  reply	other threads:[~2026-09-01 21:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 17:00 Bart Van Assche
2026-08-31  0:20 ` Bart Van Assche
2026-08-31 14:27   ` Steven Rostedt
2026-08-31 20:44 ` David Laight
2026-08-31 21:19   ` Bart Van Assche
2026-09-01  8:20     ` David Laight
2026-09-01 18:05       ` Bart Van Assche
2026-09-01 18:45         ` Linus Torvalds
2026-09-01 19:22           ` Bart Van Assche
2026-09-01 19:35             ` Linus Torvalds
2026-09-01 19:38               ` Linus Torvalds
2026-09-01 20:06               ` Bart Van Assche
2026-09-01 20:24                 ` Linus Torvalds
2026-09-01 22:46                   ` Bart Van Assche
2026-09-05  7:48                     ` Uwe Kleine-König
2026-09-01 21:29         ` David Laight
2026-09-01 21:43           ` Bart Van Assche [this message]
2026-09-01 21:56             ` Linus Torvalds
2026-09-01 23:25               ` Steven Rostedt
2026-09-02  8:24                 ` David Laight
2026-09-02 13:36                   ` Steven Rostedt
2026-09-02 15:16                     ` David Laight
2026-09-02 16:31                     ` Bart Van Assche
2026-09-02 16:39                       ` Steven Rostedt
2026-09-02 16:44                         ` Bart Van Assche
2026-09-02 16:54                           ` Steven Rostedt
2026-09-02 17:04                             ` Linus Torvalds
2026-09-02 17:24                               ` Steven Rostedt
2026-09-02 18:06                           ` David Laight
2026-09-02 18:21                             ` Steven Rostedt
2026-09-02 20:50                               ` David Laight
2026-09-02 22:40                                 ` Bart Van Assche
2026-09-02 22:43                                 ` Linus Torvalds
2026-09-02 16:52                         ` Linus Torvalds
2026-09-03 21:50                 ` Vincent Mailhol
2026-09-04  0:26                   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b86ccbf-4e41-4a26-9d22-8bd93bacb043@acm.org \
    --to=bvanassche@acm.org \
    --cc=david.laight.linux@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®