mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Chris Li <sparse@chrisli.org>
Subject: Re: [PATCH v2] tracing: Make is_signed_type() compatible with sparse
Date: Tue, 1 Sep 2026 09:20:43 +0100	[thread overview]
Message-ID: <20260901092043.7feaf5d7@pumpkin> (raw)
In-Reply-To: <a771af57-40ee-433a-be84-9b7c3e6965c5@acm.org>

On Mon, 31 Aug 2026 14:19:10 -0700
Bart Van Assche <bvanassche@acm.org> wrote:

> On 8/31/26 1:44 PM, David Laight wrote:
> > On Fri,  7 Aug 2026 10:00:56 -0700
> > Bart Van Assche <bvanassche@acm.org> wrote:
> >   
> >> Using a __bitwise type in a tracing __field() definition triggers four
> >> sparse warnings in stage 4 of expanding the TRACE_EVENT() macro. These
> >> warnings are triggered by the is_signed_type() macro implementation.
> >> Fix this by using _Generic() in the is_signed_type() implementation
> >> instead of an integer comparison.  
> > 
> > Does adding __force to the LH cast remove the warning?
> > Is so that would be a much better fix.  
> I have tried this, but unfortunately this doesn't suppress the sparse
> complaints about the casts in the is_signed_type() implementation.

The _Generic() version just doesn't work.
You need to explicitly specify all the qualified types, so you need
'int', 'const int', 'volatile int', 'const volatile int' (etc).
And, IIRC, there is another qualified in the latest C version that
would need to be allowed for as well.

I suspect you need to change the TRACE_EVENT() calls to remove the
__bitwise marker.

David

> 
> Thanks,
> 
> Bart.


  reply	other threads:[~2026-09-01  8:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 17:00 Bart Van Assche
2026-08-31  0:20 ` Bart Van Assche
2026-08-31 14:27   ` Steven Rostedt
2026-08-31 20:44 ` David Laight
2026-08-31 21:19   ` Bart Van Assche
2026-09-01  8:20     ` David Laight [this message]
2026-09-01 18:05       ` Bart Van Assche
2026-09-01 18:45         ` Linus Torvalds
2026-09-01 19:22           ` Bart Van Assche
2026-09-01 19:35             ` Linus Torvalds
2026-09-01 19:38               ` Linus Torvalds
2026-09-01 20:06               ` Bart Van Assche
2026-09-01 20:24                 ` Linus Torvalds
2026-09-01 22:46                   ` Bart Van Assche
2026-09-05  7:48                     ` Uwe Kleine-König
2026-09-01 21:29         ` David Laight
2026-09-01 21:43           ` Bart Van Assche
2026-09-01 21:56             ` Linus Torvalds
2026-09-01 23:25               ` Steven Rostedt
2026-09-02  8:24                 ` David Laight
2026-09-02 13:36                   ` Steven Rostedt
2026-09-02 15:16                     ` David Laight
2026-09-02 16:31                     ` Bart Van Assche
2026-09-02 16:39                       ` Steven Rostedt
2026-09-02 16:44                         ` Bart Van Assche
2026-09-02 16:54                           ` Steven Rostedt
2026-09-02 17:04                             ` Linus Torvalds
2026-09-02 17:24                               ` Steven Rostedt
2026-09-02 18:06                           ` David Laight
2026-09-02 18:21                             ` Steven Rostedt
2026-09-02 20:50                               ` David Laight
2026-09-02 22:40                                 ` Bart Van Assche
2026-09-02 22:43                                 ` Linus Torvalds
2026-09-02 16:52                         ` Linus Torvalds
2026-09-03 21:50                 ` Vincent Mailhol
2026-09-04  0:26                   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901092043.7feaf5d7@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®