From: Bart Van Assche <bvanassche@acm.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chris Li <sparse@chrisli.org>
Subject: [PATCH v2] tracing: Make is_signed_type() compatible with sparse
Date: Fri, 7 Aug 2026 10:00:56 -0700 [thread overview]
Message-ID: <bde573c1a758505339239f08be28788a34dfcb73.1786121949.git.bvanassche@acm.org> (raw)
Using a __bitwise type in a tracing __field() definition triggers four
sparse warnings in stage 4 of expanding the TRACE_EVENT() macro. These
warnings are triggered by the is_signed_type() macro implementation.
Fix this by using _Generic() in the is_signed_type() implementation
instead of an integer comparison.
An earlier attempt to fix this issue is available here:
https://lore.kernel.org/all/20220717151047.19220-1-bvanassche@acm.org/
Cc: Christoph Hellwig <hch@lst.de>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
Changes compared to v1: removed #ifdef __CHECKER__.
include/linux/compiler.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index cb2f6050bdf7..ba9c7e16802d 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -326,7 +326,14 @@ static inline void *offset_to_ptr(const int *off)
* Whether 'type' is a signed type or an unsigned type. Supports scalar types,
* bool and also pointer types.
*/
-#define is_signed_type(type) (((type)(-1)) < (__force type)1)
+#define is_signed_type(type) _Generic((type)0, \
+ signed char: true, \
+ signed short: true, \
+ signed int: true, \
+ signed long: true, \
+ signed long long: true, \
+ char: ((char)-1 < (char)1), \
+ default: false)
#define is_unsigned_type(type) (!is_signed_type(type))
/*
next reply other threads:[~2026-08-07 17:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 17:00 Bart Van Assche [this message]
2026-08-31 0:20 ` Bart Van Assche
2026-08-31 14:27 ` Steven Rostedt
2026-08-31 20:44 ` David Laight
2026-08-31 21:19 ` Bart Van Assche
2026-09-01 8:20 ` David Laight
2026-09-01 18:05 ` Bart Van Assche
2026-09-01 18:45 ` Linus Torvalds
2026-09-01 19:22 ` Bart Van Assche
2026-09-01 19:35 ` Linus Torvalds
2026-09-01 19:38 ` Linus Torvalds
2026-09-01 20:06 ` Bart Van Assche
2026-09-01 20:24 ` Linus Torvalds
2026-09-01 22:46 ` Bart Van Assche
2026-09-05 7:48 ` Uwe Kleine-König
2026-09-01 21:29 ` David Laight
2026-09-01 21:43 ` Bart Van Assche
2026-09-01 21:56 ` Linus Torvalds
2026-09-01 23:25 ` Steven Rostedt
2026-09-02 8:24 ` David Laight
2026-09-02 13:36 ` Steven Rostedt
2026-09-02 15:16 ` David Laight
2026-09-02 16:31 ` Bart Van Assche
2026-09-02 16:39 ` Steven Rostedt
2026-09-02 16:44 ` Bart Van Assche
2026-09-02 16:54 ` Steven Rostedt
2026-09-02 17:04 ` Linus Torvalds
2026-09-02 17:24 ` Steven Rostedt
2026-09-02 18:06 ` David Laight
2026-09-02 18:21 ` Steven Rostedt
2026-09-02 20:50 ` David Laight
2026-09-02 22:40 ` Bart Van Assche
2026-09-02 22:43 ` Linus Torvalds
2026-09-02 16:52 ` Linus Torvalds
2026-09-03 21:50 ` Vincent Mailhol
2026-09-04 0:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde573c1a758505339239f08be28788a34dfcb73.1786121949.git.bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®