From: Bart Van Assche <bvanassche@acm.org>
To: David Laight <david.laight.linux@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Chris Li <sparse@chrisli.org>
Subject: Re: [PATCH v2] tracing: Make is_signed_type() compatible with sparse
Date: Wed, 2 Sep 2026 15:40:24 -0700 [thread overview]
Message-ID: <cac520d3-6d3e-4695-9d10-ebd14dc4e398@acm.org> (raw)
In-Reply-To: <20260902215019.5d0c930a@pumpkin>
On 9/2/26 1:50 PM, David Laight wrote:
> It seems to be an attempt to generate strongly typed integers, but it doesn't
> stop you mixing up the values between the fields - there is only one kind
> of __bitwise.
That's wrong. Every __bitwise type is treated as a different type by
sparse. Otherwise e.g. __le32 and __be32 would be treated as the same
type by sparse.
$ git grep 'typedef.*__bitwise.*__[lb]e.*;' include
include/uapi/linux/types.h:typedef __u16 __bitwise __le16;
include/uapi/linux/types.h:typedef __u16 __bitwise __be16;
include/uapi/linux/types.h:typedef __u32 __bitwise __le32;
include/uapi/linux/types.h:typedef __u32 __bitwise __be32;
include/uapi/linux/types.h:typedef __u64 __bitwise __le64;
include/uapi/linux/types.h:typedef __u64 __bitwise __be64;
Bart.
next prev parent reply other threads:[~2026-09-02 22:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 17:00 Bart Van Assche
2026-08-31 0:20 ` Bart Van Assche
2026-08-31 14:27 ` Steven Rostedt
2026-08-31 20:44 ` David Laight
2026-08-31 21:19 ` Bart Van Assche
2026-09-01 8:20 ` David Laight
2026-09-01 18:05 ` Bart Van Assche
2026-09-01 18:45 ` Linus Torvalds
2026-09-01 19:22 ` Bart Van Assche
2026-09-01 19:35 ` Linus Torvalds
2026-09-01 19:38 ` Linus Torvalds
2026-09-01 20:06 ` Bart Van Assche
2026-09-01 20:24 ` Linus Torvalds
2026-09-01 22:46 ` Bart Van Assche
2026-09-05 7:48 ` Uwe Kleine-König
2026-09-01 21:29 ` David Laight
2026-09-01 21:43 ` Bart Van Assche
2026-09-01 21:56 ` Linus Torvalds
2026-09-01 23:25 ` Steven Rostedt
2026-09-02 8:24 ` David Laight
2026-09-02 13:36 ` Steven Rostedt
2026-09-02 15:16 ` David Laight
2026-09-02 16:31 ` Bart Van Assche
2026-09-02 16:39 ` Steven Rostedt
2026-09-02 16:44 ` Bart Van Assche
2026-09-02 16:54 ` Steven Rostedt
2026-09-02 17:04 ` Linus Torvalds
2026-09-02 17:24 ` Steven Rostedt
2026-09-02 18:06 ` David Laight
2026-09-02 18:21 ` Steven Rostedt
2026-09-02 20:50 ` David Laight
2026-09-02 22:40 ` Bart Van Assche [this message]
2026-09-02 22:43 ` Linus Torvalds
2026-09-02 16:52 ` Linus Torvalds
2026-09-03 21:50 ` Vincent Mailhol
2026-09-04 0:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cac520d3-6d3e-4695-9d10-ebd14dc4e398@acm.org \
--to=bvanassche@acm.org \
--cc=david.laight.linux@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®