* [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL
@ 2016-09-18 18:01 Masahiro Yamada
2016-09-19 0:08 ` Greg Ungerer
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2016-09-18 18:01 UTC (permalink / raw)
To: linux-m68k
Cc: Stephen Boyd, Ralf Baechle, Michael Turquette, Masahiro Yamada,
Geert Uytterhoeven, Greg Ungerer, linux-kernel
In many of clk_disable() implementations, it is a no-op for a NULL
pointer input, but this is one of the exceptions.
Making it treewide consistent will allow clock consumers to call
clk_disable() without NULL pointer check.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
---
Changes in v4:
- Split into per-arch patches
Changes in v3:
- Return only when clk is NULL. Do not take care of error pointer.
Changes in v2:
- Rebase on Linux 4.6-rc1
arch/m68k/coldfire/clk.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c
index fddfdcc..1e3c7e9 100644
--- a/arch/m68k/coldfire/clk.c
+++ b/arch/m68k/coldfire/clk.c
@@ -101,6 +101,10 @@ EXPORT_SYMBOL(clk_enable);
void clk_disable(struct clk *clk)
{
unsigned long flags;
+
+ if (!clk)
+ return;
+
spin_lock_irqsave(&clk_lock, flags);
if ((--clk->enabled == 0) && clk->clk_ops)
clk->clk_ops->disable(clk);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL
2016-09-18 18:01 [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL Masahiro Yamada
@ 2016-09-19 0:08 ` Greg Ungerer
0 siblings, 0 replies; 2+ messages in thread
From: Greg Ungerer @ 2016-09-19 0:08 UTC (permalink / raw)
To: Masahiro Yamada, linux-m68k
Cc: Stephen Boyd, Ralf Baechle, Michael Turquette,
Geert Uytterhoeven, linux-kernel
Hi Masahiro,
On 19/09/16 04:01, Masahiro Yamada wrote:
> In many of clk_disable() implementations, it is a no-op for a NULL
> pointer input, but this is one of the exceptions.
>
> Making it treewide consistent will allow clock consumers to call
> clk_disable() without NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
I will apply to my m68knommu git tree (for-next) branch.
Thanks
Greg
> ---
>
> Changes in v4:
> - Split into per-arch patches
>
> Changes in v3:
> - Return only when clk is NULL. Do not take care of error pointer.
>
> Changes in v2:
> - Rebase on Linux 4.6-rc1
>
> arch/m68k/coldfire/clk.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c
> index fddfdcc..1e3c7e9 100644
> --- a/arch/m68k/coldfire/clk.c
> +++ b/arch/m68k/coldfire/clk.c
> @@ -101,6 +101,10 @@ EXPORT_SYMBOL(clk_enable);
> void clk_disable(struct clk *clk)
> {
> unsigned long flags;
> +
> + if (!clk)
> + return;
> +
> spin_lock_irqsave(&clk_lock, flags);
> if ((--clk->enabled == 0) && clk->clk_ops)
> clk->clk_ops->disable(clk);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 18:01 [PATCH v4] m68k: let clk_disable() return immediately if clk is NULL Masahiro Yamada
2016-09-19 0:08 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®