[PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

[PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

[Mukesh Ojha]

After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to be invalid. So, better to name it as
"timers:prepare".

Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Brendan Jackman <brendan.jackman@arm.com>
Cc: Mathieu Malaterre <malat@debian.org>
---
Changes in v2:
 - Updated commit text.

 kernel/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 0db8938..8e6606a 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
 	 * otherwise a RCU stall occurs.
 	 */
 	[CPUHP_TIMERS_PREPARE] = {
-		.name			= "timers:dead",
+		.name			= "timers:prepare",
 		.startup.single		= timers_prepare_cpu,
 		.teardown.single	= timers_dead_cpu,
 	},
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

[Mukesh Ojha]

Hi All,

Can i get input on this ?

Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
> After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
> on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
> instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
> for timer looks to be invalid. So, better to name it as
> "timers:prepare".
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Brendan Jackman <brendan.jackman@arm.com>
> Cc: Mathieu Malaterre <malat@debian.org>
> ---
> Changes in v2:
>   - Updated commit text.
>
>   kernel/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 0db8938..8e6606a 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
>   	 * otherwise a RCU stall occurs.
>   	 */
>   	[CPUHP_TIMERS_PREPARE] = {
> -		.name			= "timers:dead",
> +		.name			= "timers:prepare",
>   		.startup.single		= timers_prepare_cpu,
>   		.teardown.single	= timers_dead_cpu,
>   	},

Re: [PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

[Thomas Gleixner]

Mukesh,

On Thu, 26 Jul 2018, Mukesh Ojha wrote:

> Hi All,
> 
> Can i get input on this ?

Sure.

> Thanks,
> Mukesh
> On 7/24/2018 8:17 PM, Mukesh Ojha wrote:

The input you get is that it's unprofessional to poke people after TWO days
about a patch which is purely cosmetic.

It's perfectly fine to send a reminder after a week for important changes
and after two for trivial cleanups like this. You really cannot expect that
maintainers and other developers permanentely sit there twiddling thumbs
and wait for new mail to arrive in order to reply immediately.

Thanks,

	tglx

Re: [PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

[Mukesh Ojha]

On 7/30/2018 5:49 PM, Thomas Gleixner wrote:
> Mukesh,
>
> On Thu, 26 Jul 2018, Mukesh Ojha wrote:
>
>> Hi All,
>>
>> Can i get input on this ?
> Sure.
>
>> Thanks,
>> Mukesh
>> On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
> The input you get is that it's unprofessional to poke people after TWO days
> about a patch which is purely cosmetic.
>
> It's perfectly fine to send a reminder after a week for important changes
> and after two for trivial cleanups like this. You really cannot expect that
> maintainers and other developers permanentely sit there twiddling thumbs
> and wait for new mail to arrive in order to reply immediately.

Thanks for your patience and time in replying.
Will keep the patience :-)

Regards,
Mukesh

>
> Thanks,
>
> 	tglx
>

[tip:smp/hotplug] cpu/hotplug: Clarify CPU hotplug step name for timers

[tip-bot for Mukesh Ojha]

Commit-ID:  d018031f562b9c2eff038969ab1955a370c52d8f
Gitweb:     https://git.kernel.org/tip/d018031f562b9c2eff038969ab1955a370c52d8f
Author:     Mukesh Ojha <mojha@codeaurora.org>
AuthorDate: Tue, 24 Jul 2018 20:17:48 +0530
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 30 Jul 2018 21:30:52 +0200

cpu/hotplug: Clarify CPU hotplug step name for timers

After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases on hotplug")
i.e. the introduction of state CPUHP_TIMERS_PREPARE instead of
CPUHP_TIMERS_DEAD the step name "timers:dead" is not longer accurate.

Rename it to "timers:prepare".

[ tglx: Massaged changelog ]

Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: gkohli@codeaurora.org
Cc: neeraju@codeaurora.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Brendan Jackman <brendan.jackman@arm.com>
Cc: Mathieu Malaterre <malat@debian.org>
Link: https://lkml.kernel.org/r/1532443668-26810-1-git-send-email-mojha@codeaurora.org

---
 kernel/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 0db8938fbb23..8e6606ac3d72 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1274,7 +1274,7 @@ static struct cpuhp_step cpuhp_hp_states[] = {
 	 * otherwise a RCU stall occurs.
 	 */
 	[CPUHP_TIMERS_PREPARE] = {
-		.name			= "timers:dead",
+		.name			= "timers:prepare",
 		.startup.single		= timers_prepare_cpu,
 		.teardown.single	= timers_dead_cpu,
 	},