mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: vamshi gajjela <vamshigajjela@google.com>,
	martin.petersen@oracle.com,
	James.Bottomley@HansenPartnership.com, avri.altman@wdc.com,
	alim.akhtar@samsung.com
Cc: peter.wang@mediatek.com, quic_nguyenb@quicinc.com,
	adrian.hunter@intel.com, beanhuo@micron.com,
	arthur.simchaev@sandisk.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events
Date: Wed, 4 Mar 2026 09:03:33 -0600	[thread overview]
Message-ID: <1dff34c7-a642-45ec-8a98-6d57b5b67b4e@acm.org> (raw)
In-Reply-To: <20260302180117.2797184-1-vamshigajjela@google.com>

On 3/2/26 12:01 PM, vamshi gajjela wrote:
> -static irqreturn_t ufshcd_handle_mcq_cq_events(struct ufs_hba *hba)
> +static irqreturn_t ufshcd_handle_mcq_cq_events(struct ufs_hba *hba, bool iag)

Please change the name of the "iag" argument into "reset_iag" to make
the purpose of this argument more clear.

> +		/* Clear MCQ IAG counter and timer of the CQ */

Please remove the above comment since it duplicates the explanation of
the "iag" argument.

Otherwise this patch looks good to me.

Thanks,

Bart.

      parent reply	other threads:[~2026-03-04 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 18:01 vamshi gajjela
2026-03-03 10:25 ` Peter Wang (王信友)
2026-03-04 15:02   ` Bart Van Assche
2026-03-05  3:28     ` Peter Wang (王信友)
2026-03-05 12:07       ` Bart Van Assche
2026-03-06  3:49         ` Peter Wang (王信友)
2026-03-06 16:22           ` VAMSHI GAJJELA
2026-03-04 15:03 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dff34c7-a642-45ec-8a98-6d57b5b67b4e@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=arthur.simchaev@sandisk.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=vamshigajjela@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®