mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "vamshigajjela@google.com" <vamshigajjela@google.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>
Cc: "beanhuo@micron.com" <beanhuo@micron.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"arthur.simchaev@sandisk.com" <arthur.simchaev@sandisk.com>
Subject: Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events
Date: Tue, 3 Mar 2026 10:25:35 +0000	[thread overview]
Message-ID: <1fa500fdfbfff7d43bea1839ce1992fb4283c5eb.camel@mediatek.com> (raw)
In-Reply-To: <20260302180117.2797184-1-vamshigajjela@google.com>

On Mon, 2026-03-02 at 23:31 +0530, vamshi gajjela wrote:
> @@ -7141,7 +7149,10 @@ static irqreturn_t ufshcd_sl_intr(struct
> ufs_hba *hba, u32 intr_status)
>  		retval |= ufshcd_transfer_req_compl(hba);
>  
>  	if (intr_status & MCQ_CQ_EVENT_STATUS)
> -		retval |= ufshcd_handle_mcq_cq_events(hba);
> +		retval |= ufshcd_handle_mcq_cq_events(hba, false);
> +
> +	if (intr_status & MCQ_IAG_EVENT_STATUS)
> +		retval |= ufshcd_handle_mcq_cq_events(hba, true);

Hi Vamshi,

This is strange to me.
Why does receiving an IAG_EVENT call ufshcd_handle_mcq_cq_events?
Shouldn't it be ufshcd_handle_mcq_iag_events instead?

Thanks
Peter


  reply	other threads:[~2026-03-03 10:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 18:01 vamshi gajjela
2026-03-03 10:25 ` Peter Wang (王信友) [this message]
2026-03-04 15:02   ` Bart Van Assche
2026-03-05  3:28     ` Peter Wang (王信友)
2026-03-05 12:07       ` Bart Van Assche
2026-03-06  3:49         ` Peter Wang (王信友)
2026-03-06 16:22           ` VAMSHI GAJJELA
2026-03-04 15:03 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fa500fdfbfff7d43bea1839ce1992fb4283c5eb.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=arthur.simchaev@sandisk.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=vamshigajjela@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®