From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "vamshigajjela@google.com" <vamshigajjela@google.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>
Cc: "beanhuo@micron.com" <beanhuo@micron.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"arthur.simchaev@sandisk.com" <arthur.simchaev@sandisk.com>
Subject: Re: [PATCH] scsi: ufs: core: Handle MCQ IAG events
Date: Fri, 6 Mar 2026 03:49:29 +0000 [thread overview]
Message-ID: <8b1faf1871c067c28e25f1248d0f358facde38b7.camel@mediatek.com> (raw)
In-Reply-To: <c18581fb-d44a-4aff-973c-27cdcc9683fa@acm.org>
On Thu, 2026-03-05 at 06:07 -0600, Bart Van Assche wrote
>
> Hi Peter,
>
> It is not clear to me why the above code is considered confusing?
>
> UFS controllers are the only storage controllers I know of
> that generate different interrupts depending on whether or not
> interrupt
> aggregation is enabled. All other storage controllers I know of use
> the
> same completion interrupt whether or not interrupt aggregation is
> enabled.
>
> To me the above code means that whether or not interrupt aggregation
> is
> enabled, ufshcd_handle_mcq_cq_events() is called to process the
> pending
> completions.
>
> Thanks,
>
> Bart.
Hi Bart,
Sorry, I may not have explained it clearly enough. Normally,
the logic is to handle A when receiving A event, and handle B
when receiving B event. But now, the code seems to be hnadle A
when receiving B event.
If not familiar with this hardware logic, it’s easy to
misunderstand.
Thanks
Peter
next prev parent reply other threads:[~2026-03-06 3:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 18:01 vamshi gajjela
2026-03-03 10:25 ` Peter Wang (王信友)
2026-03-04 15:02 ` Bart Van Assche
2026-03-05 3:28 ` Peter Wang (王信友)
2026-03-05 12:07 ` Bart Van Assche
2026-03-06 3:49 ` Peter Wang (王信友) [this message]
2026-03-06 16:22 ` VAMSHI GAJJELA
2026-03-04 15:03 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1faf1871c067c28e25f1248d0f358facde38b7.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=arthur.simchaev@sandisk.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
--cc=vamshigajjela@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®