From: Jan Hudec <bulb@ucw.cz>
To: "Peter T. Breuer" <ptb@it.uc3m.es>
Cc: William Lee Irwin III <wli@holomorphy.com>,
"Martin J. Bligh" <mbligh@aracnet.com>,
linux-kernel@vger.kernel.org
Subject: Re: recursive spinlocks. Shoot.
Date: Mon, 19 May 2003 08:19:39 +0200 [thread overview]
Message-ID: <20030519061939.GB944@vagabond> (raw)
In-Reply-To: <200305181724.h4IHOHU24241@oboe.it.uc3m.es>
On Sun, May 18, 2003 at 07:24:17PM +0200, Peter T. Breuer wrote:
> "A month of sundays ago William Lee Irwin III wrote:"
> > At some point in the past, Peter Breuer's attribution was removed from:
> > >> Here's a before-breakfast implementation of a recursive spinlock. That
> > >> is, the same thread can "take" the spinlock repeatedly.
> >
> > On Sun, May 18, 2003 at 09:30:17AM -0700, Martin J. Bligh wrote:
> > > Why?
> >
> > netconsole.
>
> That's a problem looking for a solution! No, the reason for wanting a
> recursive spinlock is that nonrecursive locks make programming harder.
>
> Though I've got quite good at finding and removing deadlocks in my old
> age, there are still two popular ways that the rest of the world's
> prgrammers often shoot themselves in the foot with a spinlock:
>
> a) sleeping while holding the spinlock
> b) taking the spinlock in a subroutine while you already have it
>
> The first method leads to an early death if the spinlock is a popular
> one, as the only thread that can release it doesn't seem to be running,
> errr..
>
> The second method is used by programmers who aren't aware that some
> obscure subroutine takes a spinlock, and who recklessly take a lock
> before calling a subroutine (the very thought sends shivers down my
> spine ...). A popular scenario involves not /knowing/ that your routine
> is called by the kernel with some obscure lock already held, and then
> calling a subroutine that calls the same obscure lock. The request
> function is one example, but that's hardly obscure (and in 2.5 the
> situation has eased there!).
>
> It's the case (b) that a recursive spinlock makes go away.
It thought we still have the spinlock debuging level 2 which DOES CHECK
THIS (seems noone knows about it - I had to fix a trivial error when
I used it in user-mode arch, but it worked well then). [check means it
gives backtrace]
> Hey, that's not bad for a small change! 50% of potential programming
> errors sent to the dustbin without ever being encountered.
They are errors. Appropriate response to errors is an OOPS.
-------------------------------------------------------------------------------
Jan 'Bulb' Hudec <bulb@ucw.cz>
next prev parent reply other threads:[~2003-05-19 6:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-18 9:21 Peter T. Breuer
2003-05-18 16:30 ` Martin J. Bligh
2003-05-18 16:35 ` William Lee Irwin III
2003-05-18 16:49 ` Arjan van de Ven
2003-05-18 16:54 ` William Lee Irwin III
2003-05-18 17:14 ` Martin J. Bligh
2003-05-18 17:24 ` Peter T. Breuer
2003-05-18 22:34 ` David Woodhouse
2003-05-19 13:37 ` Peter T. Breuer
2003-05-19 13:45 ` Jens Axboe
2003-05-19 13:47 ` Arjan van de Ven
[not found] ` <mailman.1053352200.24653.linux-kernel2news@redhat.com>
2003-05-19 23:54 ` Pete Zaitcev
2003-05-20 0:03 ` viro
2003-05-20 0:03 ` Johannes Erdfelt
2003-05-20 3:12 ` Robert White
2003-05-20 11:59 ` Helge Hafting
2003-05-20 12:23 ` Richard B. Johnson
2003-05-20 21:05 ` Robert White
2003-05-20 21:42 ` Richard B. Johnson
2003-05-20 23:06 ` Robert White
2003-05-21 14:01 ` Richard B. Johnson
2003-05-21 21:56 ` Robert White
2003-05-22 0:13 ` viro
2003-05-22 0:32 ` Robert White
2003-05-22 0:46 ` Carl-Daniel Hailfinger
2003-05-21 5:48 ` Nikita Danilov
2003-05-22 1:00 ` Rik van Riel
2003-05-22 3:11 ` Robert White
2003-05-22 4:04 ` Nick Piggin
2003-05-22 4:42 ` Peter T. Breuer
2003-05-22 5:09 ` Nick Piggin
2003-05-23 0:19 ` Robert White
2003-05-23 7:22 ` Nikita Danilov
2003-05-23 9:07 ` Helge Hafting
2003-05-23 12:18 ` William Lee Irwin III
2003-05-24 2:39 ` Robert White
2003-05-28 16:50 ` Timothy Miller
2003-05-19 2:05 ` Kevin O'Connor
2003-05-19 6:19 ` Jan Hudec [this message]
2003-05-19 10:29 ` Helge Hafting
2003-05-19 11:37 ` Nikita Danilov
2003-05-22 1:21 ` Daniel Phillips
2003-05-19 14:28 ` Martin J. Bligh
2003-05-18 18:13 ` Davide Libenzi
[not found] <20030518182010$0541@gated-at.bofh.it>
2003-05-18 19:09 ` Peter T. Breuer
2003-05-18 19:31 ` Davide Libenzi
2003-05-18 19:49 ` Peter T. Breuer
2003-05-18 20:13 ` Davide Libenzi
2003-05-19 20:47 ` Jan Hudec
[not found] <20030518202013$5297@gated-at.bofh.it>
2003-05-18 23:15 ` Peter T. Breuer
2003-05-18 23:26 ` Davide Libenzi
2003-05-19 12:48 ` Peter T. Breuer
2003-05-19 17:15 ` Davide Libenzi
2003-05-19 17:27 ` Peter T. Breuer
2003-05-19 17:57 ` Alan Cox
2003-05-19 19:51 ` Peter T. Breuer
2003-05-19 20:22 ` Robert White
[not found] <20030520231013$3d77@gated-at.bofh.it>
2003-05-21 14:16 ` Peter T. Breuer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030519061939.GB944@vagabond \
--to=bulb@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=ptb@it.uc3m.es \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®