Re: Linux 2.6.3-rc4

[Adrian Bunk <bunk@fs.tum.de>]

On Tue, Feb 17, 2004 at 11:09:45AM -0800, Linus Torvalds wrote:
> 
> 
> On Tue, 17 Feb 2004, GCS wrote:
> >
> > drivers/built-in.o(.text+0xb2c44): In function `radeon_do_probe_i2c_edid':
> > : undefined reference to `i2c_transfer'
> > make: *** [.tmp_vmlinux1] Error 1
> > 
> > .config snippshet:
> > # CONFIG_FB_RADEON_OLD is not set
> > CONFIG_FB_RADEON=y
> > CONFIG_FB_RADEON_I2C=y
> > CONFIG_FB_RADEON_DEBUG=y
> 
> I don't see this. What's your I2C config, and how did you generate your 
> config file?
> 
> CONFIG_FB_RADEON_I2C should depend on CONFIG_I2C, and it selects 
> I2C_ALGOBIT, but your error messages seem to imply that you don't have i2c 
> enabled at all.
> 
> Which implies a configuration error (but the Kconfig file looks correct, 
> so I wonder if you found a bug in the configurator).

Most likely the problem is CONFIG_I2C=m and the fact that FB_RADEON_I2C
is a bool.

I don't know whether there's a better way to express this, but something 
like the following is required:

--- linux-2.6.3-rc4/drivers/video/Kconfig.old	2004-02-17 21:00:24.000000000 +0100
+++ linux-2.6.3-rc4/drivers/video/Kconfig	2004-02-17 21:01:53.000000000 +0100
@@ -644,7 +644,7 @@
 
 config FB_RADEON_I2C
 	bool "DDC/I2C for ATI Radeon support"
-	depends on FB_RADEON && I2C
+	depends on (FB_RADEON=m && I2C) || (FB_RADEON=y && I2C=y)
 	select I2C_ALGOBIT
 	default y
 	help


> 		Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed