mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: zippel@linux-m68k.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	GCS <gcs@lsc.hu>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	vandrove@vc.cvut.cz
Subject: Re: Linux 2.6.3-rc4
Date: Wed, 18 Feb 2004 01:00:28 +0100	[thread overview]
Message-ID: <20040218000028.GR1308@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0402171503150.2154@home.osdl.org>

On Tue, Feb 17, 2004 at 03:11:08PM -0800, Linus Torvalds wrote:
> 
> 
> On Tue, 17 Feb 2004, Adrian Bunk wrote:
> > 
> > No, I2C_ALGOBIT depends on I2C.
> > 
> > > That's really what the true dependency is, logically.
> > 
> > Below is a suggested fix that lets FB_RADEON_I2C select I2C.
> 
> Thinking about it, this does the wrong thing for _another_ reason.
> 
> Basically, if you compile radeonfb as a module, and say "Y" to RADEON_I2C, 
> then that should _not_ force I2C to be built-in to the kernel, but that 
> is in fact exactly what this would force.
>...

I don't claim to fully understand the 2.6 Kconfig language, but 
according to my testings my patch does exactly what you describe.

> 			Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2004-02-18  0:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-17  3:51 Linus Torvalds
2004-02-17  6:19 ` Felix Seeger
2004-02-17  8:54 ` Martin Diehl
2004-02-17  9:27   ` Martin Diehl
2004-02-17 15:39   ` Bartlomiej Zolnierkiewicz
2004-02-17 16:21 ` Linux 2.6.3-rc4 (compile stats) John Cherry
2004-02-17 18:45 ` Linux 2.6.3-rc4 GCS
2004-02-17 19:09   ` Linus Torvalds
2004-02-17 20:05     ` Adrian Bunk
2004-02-17 20:16       ` Linus Torvalds
2004-02-17 22:59         ` Adrian Bunk
2004-02-17 23:11           ` Linus Torvalds
2004-02-17 23:37             ` Radeon issue on x86 Benjamin Herrenschmidt
2004-02-18  0:17               ` Linus Torvalds
2004-02-18  0:33                 ` Benjamin Herrenschmidt
2004-02-18  0:00             ` Adrian Bunk [this message]
2004-02-18  1:28               ` Linux 2.6.3-rc4 Roman Zippel
2004-02-18  0:39             ` Roman Zippel
2004-02-18  1:06             ` Roman Zippel
2004-02-18  2:45           ` Roman Zippel
2004-02-18  2:58             ` Linus Torvalds
2004-02-18  0:15       ` Roman Zippel
2004-02-18  0:21     ` GCS
2004-02-17 18:56 ` Jonathan Brown
2004-02-17 19:06   ` Linus Torvalds
2004-02-18 10:18   ` Andreas Happe
2004-02-18  4:06 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040218000028.GR1308@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=benh@kernel.crashing.org \
    --cc=gcs@lsc.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=vandrove@vc.cvut.cz \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®