mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	GCS <gcs@lsc.hu>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	vandrove@vc.cvut.cz
Subject: Re: Linux 2.6.3-rc4
Date: Wed, 18 Feb 2004 03:45:09 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.58.0402180337100.7851@serv> (raw)
In-Reply-To: <20040217225905.GQ1308@fs.tum.de>

Hi,

On Tue, 17 Feb 2004, Adrian Bunk wrote:

> @@ -548,7 +544,8 @@
>
>  config FB_MATROX_I2C
>  	tristate "Matrox I2C support"
> -	depends on FB_MATROX && I2C
> +	depends on FB_MATROX
> +	select I2C
>  	select I2C_ALGOBIT
>  	---help---
>  	  This drivers creates I2C buses which are needed for accessing the

This was okay, this is a tristate and limited by I2C, so it will select
I2C_ALGOBIT correctly.

>  config FB_RADEON_I2C
>  	bool "DDC/I2C for ATI Radeon support"
> -	depends on FB_RADEON && I2C
> +	depends on FB_RADEON
> +	select I2C
>  	select I2C_ALGOBIT
>  	default y
>  	help

Linus, I think that's the best solution for now. I have to think a bit
more about the problem, how a boolean symbol should select a tristate
symbol.

bye, Roman

  parent reply	other threads:[~2004-02-18  2:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-17  3:51 Linus Torvalds
2004-02-17  6:19 ` Felix Seeger
2004-02-17  8:54 ` Martin Diehl
2004-02-17  9:27   ` Martin Diehl
2004-02-17 15:39   ` Bartlomiej Zolnierkiewicz
2004-02-17 16:21 ` Linux 2.6.3-rc4 (compile stats) John Cherry
2004-02-17 18:45 ` Linux 2.6.3-rc4 GCS
2004-02-17 19:09   ` Linus Torvalds
2004-02-17 20:05     ` Adrian Bunk
2004-02-17 20:16       ` Linus Torvalds
2004-02-17 22:59         ` Adrian Bunk
2004-02-17 23:11           ` Linus Torvalds
2004-02-17 23:37             ` Radeon issue on x86 Benjamin Herrenschmidt
2004-02-18  0:17               ` Linus Torvalds
2004-02-18  0:33                 ` Benjamin Herrenschmidt
2004-02-18  0:00             ` Linux 2.6.3-rc4 Adrian Bunk
2004-02-18  1:28               ` Roman Zippel
2004-02-18  0:39             ` Roman Zippel
2004-02-18  1:06             ` Roman Zippel
2004-02-18  2:45           ` Roman Zippel [this message]
2004-02-18  2:58             ` Linus Torvalds
2004-02-18  0:15       ` Roman Zippel
2004-02-18  0:21     ` GCS
2004-02-17 18:56 ` Jonathan Brown
2004-02-17 19:06   ` Linus Torvalds
2004-02-18 10:18   ` Andreas Happe
2004-02-18  4:06 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0402180337100.7851@serv \
    --to=zippel@linux-m68k.org \
    --cc=benh@kernel.crashing.org \
    --cc=bunk@fs.tum.de \
    --cc=gcs@lsc.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®