From: Al Viro <viro@ftp.linux.org.uk>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 7/8] don't mangle INQUIRY if cmddt or evpd bits are set
Date: Wed, 8 Feb 2006 23:05:59 +0000 [thread overview]
Message-ID: <20060208230559.GK27946@ftp.linux.org.uk> (raw)
In-Reply-To: <43EA7226.60306@s5r6.in-berlin.de>
On Wed, Feb 08, 2006 at 11:35:18PM +0100, Stefan Richter wrote:
> I tested the patch with 8 different SBP-2 bridges, based on 6 or 7
> different bridge chips. Works for me.
>
> In fact, not a single one of these bridges is affected by the code
> change since the additional expression which was added always evaluates
> true.
The hell it does. Try scsiinfo -s and you'll see. All INQUIRY generated
by scsi midlayer have both flags set to 0. Userland ones do not; example
I've mentioned (scsiinfo -s) will send an INQUIRY with EVPD=1 and page
code 0x80 (that's cmnd[2]), which results in response of form
(periph_qualifier << 5) | device_type
0x80
<reserved>
page length
unit serial number (page length - 3 bytes)
Similar for page 0x83 (device identification descriptors), etc. Userland
gets to those via SG_IO and yes, it's really used.
next prev parent reply other threads:[~2006-02-08 23:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 20:31 Al Viro
2006-02-08 22:35 ` Stefan Richter
2006-02-08 23:05 ` Al Viro [this message]
2006-02-08 23:51 ` Stefan Richter
2006-02-13 16:19 ` Stefan Richter
2006-02-13 17:03 ` Jody McIntyre
2006-02-13 18:18 ` Al Viro
2006-02-13 20:28 ` Stefan Richter
2006-02-14 2:40 ` Al Viro
2006-02-14 8:37 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208230559.GK27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome