From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 7/8] don't mangle INQUIRY if cmddt or evpd bits are set
Date: Wed, 08 Feb 2006 23:35:18 +0100 [thread overview]
Message-ID: <43EA7226.60306@s5r6.in-berlin.de> (raw)
In-Reply-To: <E1F6vyJ-00009k-3Z@ZenIV.linux.org.uk>
Al Viro wrote:
> Date: 1139425740 -0500
>
> sbp2.c mangles INQUIRY response in a way that only applies to standard
> inquiry data (i.e. when both cmddt and evpd bits are 0). Leave other cases
> alone; e.g. when asking for VPD the length of reply is in byte 3, not 4
> and byte 4 is the first byte of device serial number.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> ---
>
I tested the patch with 8 different SBP-2 bridges, based on 6 or 7
different bridge chips. Works for me.
In fact, not a single one of these bridges is affected by the code
change since the additional expression which was added always evaluates
true.
...
> - switch (SCpnt->cmnd[0]) {
> -
> - case INQUIRY:
> + if (SCpnt->cmnd[0] == INQUIRY && (SCpnt->cmnd[1] & 3) == 0) {
> /*
> * Make sure data length is ok. Minimum length is 36 bytes
> */
...
--
Stefan Richter
-=====-=-==- --=- -=---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-02-08 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 20:31 Al Viro
2006-02-08 22:35 ` Stefan Richter [this message]
2006-02-08 23:05 ` Al Viro
2006-02-08 23:51 ` Stefan Richter
2006-02-13 16:19 ` Stefan Richter
2006-02-13 17:03 ` Jody McIntyre
2006-02-13 18:18 ` Al Viro
2006-02-13 20:28 ` Stefan Richter
2006-02-14 2:40 ` Al Viro
2006-02-14 8:37 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EA7226.60306@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome