From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jody McIntyre <scjody@modernduck.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 7/8] don't mangle INQUIRY if cmddt or evpd bits are set
Date: Mon, 13 Feb 2006 17:19:55 +0100 [thread overview]
Message-ID: <43F0B1AB.6010708@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060208230559.GK27946@ftp.linux.org.uk>
Al Viro wrote on 2006-02-09:
> On Wed, Feb 08, 2006 at 11:35:18PM +0100, Stefan Richter wrote:
...
>>not a single one of these bridges is affected by the code
>>change since the additional expression which was added always evaluates
>>true.
>
> The hell it does. Try scsiinfo -s and you'll see. All INQUIRY generated
> by scsi midlayer have both flags set to 0. Userland ones do not;
...
OK, tested scsiinfo now with 9 bridges (8 or 7 different chips).
The patch obviously works as expected.
Jody, are you going to channel the patch through your tree?
BTW, a Prolific based enclosure indeed seems to be unable to handle
CD-ROMs after scsiinfo treatment. An enclosure based on an old
revision of TI StorageLynx apparently causes mode_sense -> check
condition/ unit attention loops when scsiinfo tries to access some
mode page.
--
Stefan Richter
-=====-=-==- --=- -==-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-02-13 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 20:31 Al Viro
2006-02-08 22:35 ` Stefan Richter
2006-02-08 23:05 ` Al Viro
2006-02-08 23:51 ` Stefan Richter
2006-02-13 16:19 ` Stefan Richter [this message]
2006-02-13 17:03 ` Jody McIntyre
2006-02-13 18:18 ` Al Viro
2006-02-13 20:28 ` Stefan Richter
2006-02-14 2:40 ` Al Viro
2006-02-14 8:37 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F0B1AB.6010708@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@modernduck.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®