mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Stephen Hemminger <shemminger@osdl.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Kprobes: Make kprobe modules more portable
Date: Tue, 8 Aug 2006 18:32:42 +0100	[thread overview]
Message-ID: <20060808173242.GA1739@infradead.org> (raw)
In-Reply-To: <44D8C9BC.40102@grupopie.com>

On Tue, Aug 08, 2006 at 06:28:28PM +0100, Paulo Marques wrote:
> Just one side note: kallsyms_lookup_name is _really_ inefficient. The 
> kallsyms structure is tailored so that kallsyms_lookup (the most 
> frequently used function) is really fast. Doing it the other way around 
> involves a O(N) search, uncompressing every symbol name as it goes :P
> 
> I don't think this is really a performance problem for users like 
> kprobes, but I just wanted people to keep in mind that there is a 
> penalty involved in calling kallsyms_lookup_name.

That's true.  One more reason to not expose this interface to the public.

  reply	other threads:[~2006-08-08 17:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07 11:55 Ananth N Mavinakayanahalli
2006-08-07 12:00 ` [PATCH 2/3] Kprobes: Define retval helper Ananth N Mavinakayanahalli
2006-08-07 12:04   ` [PATCH 3/3] Kprobes: Update Documentation/kprobes.txt Ananth N Mavinakayanahalli
2006-08-08 16:27     ` Christoph Hellwig
2006-08-09  9:48       ` Ananth N Mavinakayanahalli
2006-08-09 10:24         ` Ananth N Mavinakayanahalli
2006-08-08 16:25   ` [PATCH 2/3] Kprobes: Define retval helper Christoph Hellwig
2006-08-09  4:37     ` Andi Kleen
2006-08-09  9:43     ` Ananth N Mavinakayanahalli
2006-08-09  9:45       ` Christoph Hellwig
2006-08-09  9:55         ` Andi Kleen
2006-08-09 10:19           ` Ananth N Mavinakayanahalli
2006-08-09 10:28             ` Martin Schwidefsky
2006-08-09 13:16       ` David Howells
2006-08-09 15:20         ` Ananth N Mavinakayanahalli
2006-08-07 12:06 ` [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-08 16:24 ` Christoph Hellwig
2006-08-08 16:34   ` Stephen Hemminger
2006-08-08 16:40     ` Christoph Hellwig
2006-08-08 17:28       ` Paulo Marques
2006-08-08 17:32         ` Christoph Hellwig [this message]
2006-08-09  9:51   ` Ananth N Mavinakayanahalli
2006-08-09 16:01   ` David Smith
2006-08-09 16:10     ` Christoph Hellwig
2006-08-09 16:18       ` Christoph Hellwig
2006-08-10 14:10         ` Keshavamurthy Anil S
2006-08-16 13:20           ` Christoph Hellwig
2006-08-11  8:53         ` Ananth N Mavinakayanahalli
2006-08-10  6:18       ` Ananth N Mavinakayanahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060808173242.GA1739@infradead.org \
    --to=hch@infradead.org \
    --cc=ananth@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmarques@grupopie.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome