mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	linux-kernel@vger.kernel.org,
	Prasanna S Panchamukhi <prasanna@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/3] Kprobes: Define retval helper
Date: Wed, 9 Aug 2006 11:55:50 +0200	[thread overview]
Message-ID: <200608091155.50842.ak@suse.de> (raw)
In-Reply-To: <20060809094516.GA17993@infradead.org>


> >  #define instruction_pointer(regs) ((regs)->eip)
> > +#define get_retval(regs) ((regs)->eax)

return_value() would match the names of the existing macro better

-Andi


  reply	other threads:[~2006-08-09  9:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07 11:55 [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-07 12:00 ` [PATCH 2/3] Kprobes: Define retval helper Ananth N Mavinakayanahalli
2006-08-07 12:04   ` [PATCH 3/3] Kprobes: Update Documentation/kprobes.txt Ananth N Mavinakayanahalli
2006-08-08 16:27     ` Christoph Hellwig
2006-08-09  9:48       ` Ananth N Mavinakayanahalli
2006-08-09 10:24         ` Ananth N Mavinakayanahalli
2006-08-08 16:25   ` [PATCH 2/3] Kprobes: Define retval helper Christoph Hellwig
2006-08-09  4:37     ` Andi Kleen
2006-08-09  9:43     ` Ananth N Mavinakayanahalli
2006-08-09  9:45       ` Christoph Hellwig
2006-08-09  9:55         ` Andi Kleen [this message]
2006-08-09 10:19           ` Ananth N Mavinakayanahalli
2006-08-09 10:28             ` Martin Schwidefsky
2006-08-09 13:16       ` David Howells
2006-08-09 15:20         ` Ananth N Mavinakayanahalli
2006-08-07 12:06 ` [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-08 16:24 ` Christoph Hellwig
2006-08-08 16:34   ` Stephen Hemminger
2006-08-08 16:40     ` Christoph Hellwig
2006-08-08 17:28       ` Paulo Marques
2006-08-08 17:32         ` Christoph Hellwig
2006-08-09  9:51   ` Ananth N Mavinakayanahalli
2006-08-09 16:01   ` David Smith
2006-08-09 16:10     ` Christoph Hellwig
2006-08-09 16:18       ` Christoph Hellwig
2006-08-10 14:10         ` Keshavamurthy Anil S
2006-08-16 13:20           ` Christoph Hellwig
2006-08-11  8:53         ` Ananth N Mavinakayanahalli
2006-08-10  6:18       ` Ananth N Mavinakayanahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608091155.50842.ak@suse.de \
    --to=ak@suse.de \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=hch@infradead.org \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prasanna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome