From: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
To: Christoph Hellwig <hch@infradead.org>,
David Smith <dsmith@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
linux-kernel@vger.kernel.org, shemminger@osdl.org
Subject: Re: [PATCH 1/3] Kprobes: Make kprobe modules more portable
Date: Thu, 10 Aug 2006 07:10:29 -0700 [thread overview]
Message-ID: <20060810071028.A18344@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060809161854.GA13622@infradead.org>; from hch@infradead.org on Wed, Aug 09, 2006 at 05:18:54PM +0100
On Wed, Aug 09, 2006 at 05:18:54PM +0100, Christoph Hellwig wrote:
> + */
> + if (p->symbol_name) {
> + if (p->addr)
> + return -EINVAL;
> + p->addr = kprobe_lookup_name(p->symbol_name);
> + }
> +
> + if (!p->addr)
> + return -EINVAL;
> + p->addr += p->offset;
This should be p->addr = (kprobe_opcode_t *)(((char *)p->addr) + p->offset), since p->addr is of type
pointer to kprobe_opcode_t and the size of kprobe_opcode_t is different for different
architecture. At least for ia64 this p->addr type is not a pointer to char.
-Anil Keshavamurthy
next prev parent reply other threads:[~2006-08-10 14:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 11:55 Ananth N Mavinakayanahalli
2006-08-07 12:00 ` [PATCH 2/3] Kprobes: Define retval helper Ananth N Mavinakayanahalli
2006-08-07 12:04 ` [PATCH 3/3] Kprobes: Update Documentation/kprobes.txt Ananth N Mavinakayanahalli
2006-08-08 16:27 ` Christoph Hellwig
2006-08-09 9:48 ` Ananth N Mavinakayanahalli
2006-08-09 10:24 ` Ananth N Mavinakayanahalli
2006-08-08 16:25 ` [PATCH 2/3] Kprobes: Define retval helper Christoph Hellwig
2006-08-09 4:37 ` Andi Kleen
2006-08-09 9:43 ` Ananth N Mavinakayanahalli
2006-08-09 9:45 ` Christoph Hellwig
2006-08-09 9:55 ` Andi Kleen
2006-08-09 10:19 ` Ananth N Mavinakayanahalli
2006-08-09 10:28 ` Martin Schwidefsky
2006-08-09 13:16 ` David Howells
2006-08-09 15:20 ` Ananth N Mavinakayanahalli
2006-08-07 12:06 ` [PATCH 1/3] Kprobes: Make kprobe modules more portable Ananth N Mavinakayanahalli
2006-08-08 16:24 ` Christoph Hellwig
2006-08-08 16:34 ` Stephen Hemminger
2006-08-08 16:40 ` Christoph Hellwig
2006-08-08 17:28 ` Paulo Marques
2006-08-08 17:32 ` Christoph Hellwig
2006-08-09 9:51 ` Ananth N Mavinakayanahalli
2006-08-09 16:01 ` David Smith
2006-08-09 16:10 ` Christoph Hellwig
2006-08-09 16:18 ` Christoph Hellwig
2006-08-10 14:10 ` Keshavamurthy Anil S [this message]
2006-08-16 13:20 ` Christoph Hellwig
2006-08-11 8:53 ` Ananth N Mavinakayanahalli
2006-08-10 6:18 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810071028.A18344@unix-os.sc.intel.com \
--to=anil.s.keshavamurthy@intel.com \
--cc=ananth@in.ibm.com \
--cc=dsmith@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome