[patch 2.6.12-rc2] PNP: export pnp_bus_type

[patch 2.6.12-rc2] PNP: export pnp_bus_type

[David Brownell]

The PNP framework doesn't export "pnp_bus_type", which is an unfortunate
exception to the policy followed by pretty much every other bus.  I noticed
this when I had to find a device in order to provide its platform_data.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: g26/drivers/pnp/base.h
===================================================================
--- g26.orig/drivers/pnp/base.h	2006-12-18 05:45:29.000000000 -0800
+++ g26/drivers/pnp/base.h	2006-12-18 05:45:41.000000000 -0800
@@ -1,4 +1,3 @@
-extern struct bus_type pnp_bus_type;
 extern spinlock_t pnp_lock;
 void *pnp_alloc(long size);
 int pnp_interface_attach_device(struct pnp_dev *dev);
Index: g26/drivers/pnp/driver.c
===================================================================
--- g26.orig/drivers/pnp/driver.c	2006-07-03 10:45:14.000000000 -0700
+++ g26/drivers/pnp/driver.c	2006-12-18 05:41:56.000000000 -0800
@@ -199,6 +199,7 @@ struct bus_type pnp_bus_type = {
 	.suspend = pnp_bus_suspend,
 	.resume = pnp_bus_resume,
 };
+EXPORT_SYMBOL(pnp_bus_type);
 
 int pnp_register_driver(struct pnp_driver *drv)
 {
Index: g26/include/linux/pnp.h
===================================================================
--- g26.orig/include/linux/pnp.h	2006-12-18 05:45:29.000000000 -0800
+++ g26/include/linux/pnp.h	2006-12-27 13:22:58.000000000 -0800
@@ -352,6 +352,8 @@ struct pnp_protocol {
 	(dev) = protocol_to_pnp_dev((dev)->protocol_list.next))
 
 
+extern struct bus_type pnp_bus_type;
+
 #if defined(CONFIG_PNP)
 
 /* device management */

Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type

[Arjan van de Ven]

On Wed, 2006-12-27 at 13:47 -0800, David Brownell wrote:
> The PNP framework doesn't export "pnp_bus_type", which is an unfortunate
> exception to the policy followed by pretty much every other bus.  I noticed
> this when I had to find a device in order to provide its platform_data.

can you please merge the export together with the driver? We already
have way too many unused exports, and the only sane way is to merge the
export with the user..... (and yes exports are not free, they take up
100 to 150 bytes of kernel size for example)

Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type

[David Brownell]

On Wednesday 27 December 2006 2:30 pm, Arjan van de Ven wrote:
> On Wed, 2006-12-27 at 13:47 -0800, David Brownell wrote:
> > The PNP framework doesn't export "pnp_bus_type", which is an unfortunate
> > exception to the policy followed by pretty much every other bus.  I noticed
> > this when I had to find a device in order to provide its platform_data.
> 
> can you please merge the export together with the driver? 

I'll send that stuff along; providing the platform data is actually
an update to ACPI glue, not the driver, so the driver won't need to
become needlessly coupled to ACPI.  (Driver = rtc_cmos, I'll resend
it in a few days.)


> We already 
> have way too many unused exports, and the only sane way is to merge the
> export with the user..... (and yes exports are not free, they take up
> 100 to 150 bytes of kernel size for example)

Hmm, then maybe it'd be worth updating that patch I just sent so that
the only change is to switch #includes for the extern decl ... i.e. to
"export" it only to other statically linked kernel code, rather than to
modules.  I'll do that.

My own question about that EXPORT_SYMBOL was whether it instead be
an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
avoid that cost!

- Dave

  

Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type

[Arjan van de Ven]

> Hmm, then maybe it'd be worth updating that patch I just sent so that
> the only change is to switch #includes for the extern decl ... i.e. to
> "export" it only to other statically linked kernel code, rather than to
> modules.  I'll do that.
> 
> My own question about that EXPORT_SYMBOL was whether it instead be
> an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
> avoid that cost!

no export if it's not *really* need is obviously superior to either of
those so yes I like the patch you're talking about already without even
having seen it ;)


>   
-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type

[David Brownell]

On Thursday 28 December 2006 2:05 am, Arjan van de Ven wrote:
> 
> > Hmm, then maybe it'd be worth updating that patch I just sent so that
> > the only change is to switch #includes for the extern decl ... i.e. to
> > "export" it only to other statically linked kernel code, rather than to
> > modules.  I'll do that.
> > 
> > My own question about that EXPORT_SYMBOL was whether it instead be
> > an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
> > avoid that cost!
> 
> no export if it's not *really* need is obviously superior to either of
> those so yes I like the patch you're talking about already without even
> having seen it ;)

The change is trivial ... in pnp/driver.c strike the EXPORT_SYMBOL.
So I won't bother posting it to this list; I hate wasting electrons.

I sent the updated patch to Andrew, but evidently just missed his
2.6.20-rc2-mm1 cutoff.

- Dave