* [PATCH] Allow reading tainted flag as user
@ 2007-04-22 8:39 Bastian Blank
2007-04-22 8:50 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Bastian Blank @ 2007-04-22 8:39 UTC (permalink / raw)
To: Theodore Ts'o, linux-kernel; +Cc: akpm
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
of the tainted value. The attached patch changes this back to a
write-only check and restores the read behaviour of older versions.
Signed-off-by: Bastian Blank <bastian@waldi.eu.org>
--
The joys of love made her human and the agonies of love destroyed her.
-- Spock, "Requiem for Methuselah", stardate 5842.8
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Allow reading tainted flag as user
2007-04-22 8:39 [PATCH] Allow reading tainted flag as user Bastian Blank
@ 2007-04-22 8:50 ` Andrew Morton
2007-04-22 8:58 ` Bastian Blank
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-04-22 8:50 UTC (permalink / raw)
To: Bastian Blank; +Cc: Theodore Ts'o, linux-kernel
On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <bastian@waldi.eu.org> wrote:
> The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
> of the tainted value. The attached patch changes this back to a
> write-only check and restores the read behaviour of older versions.
>
> Signed-off-by: Bastian Blank <bastian@waldi.eu.org>
there's no patch here.
And I'd be interested to see it, because Ted's patch converted it from 0444
to 0644, which sounds right.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Allow reading tainted flag as user
2007-04-22 8:50 ` Andrew Morton
@ 2007-04-22 8:58 ` Bastian Blank
0 siblings, 0 replies; 3+ messages in thread
From: Bastian Blank @ 2007-04-22 8:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: Theodore Ts'o, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Sun, Apr 22, 2007 at 01:50:45AM -0700, Andrew Morton wrote:
> On Sun, 22 Apr 2007 10:39:41 +0200 Bastian Blank <bastian@waldi.eu.org> wrote:
>
> > The commit 34f5a39899f3f3e815da64f48ddb72942d86c366 restricted reading
> > of the tainted value. The attached patch changes this back to a
> > write-only check and restores the read behaviour of older versions.
> >
> > Signed-off-by: Bastian Blank <bastian@waldi.eu.org>
>
> there's no patch here.
Ups.
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 1b255df..c904748 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1676,7 +1676,7 @@ static int proc_dointvec_taint(ctl_table *table, int write, struct file *filp,
{
int op;
- if (!capable(CAP_SYS_ADMIN))
+ if (write && !capable(CAP_SYS_ADMIN))
return -EPERM;
op = OP_OR;
--
Captain's Log, star date 21:34.5...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-22 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-22 8:39 [PATCH] Allow reading tainted flag as user Bastian Blank
2007-04-22 8:50 ` Andrew Morton
2007-04-22 8:58 ` Bastian Blank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®