mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
To: LKML <linux-kernel@vger.kernel.org>
Cc: trivial@kernel.org
Subject: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
Date: Tue, 15 May 2007 15:17:11 -1000	[thread overview]
Message-ID: <20070516011711.GE15763@ifa.hawaii.edu> (raw)

Hello,

Below is a one line patch to possibly fix this bug:

http://bugs.gentoo.org/show_bug.cgi?id=178585
http://bugzilla.kernel.org/show_bug.cgi?id=8075

If the kernel is configured with:

CONFIG_X86_POWERNOW_K8=y
CONFIG_X86_ACPI_CPUFREQ=m

Which is currently an allowed configuration, the powernow-k8 driver on
an SMP system will fail with a warning like:

powernow-k8: Found 4 Dual Core AMD Opteron(tm) Processor 285 processors (version 2.00.00)
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure

Which mimics that failure you get when powernow/cool'n'quiet is disabled
in the BIOS.  I don't know if this config combination is valid on a
uniprocessor system so this dependency may need to be enforced only if
SMP in enabled.  The other powernow-* drivers likely have the same
requirements as -k8 but I am unable to test them.

Signed-off-by: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
--
 Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig    2007-04-27 11:49:26.000000000 -1000
+++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15 14:48:50.000000000 -1000
@@ -82,6 +82,7 @@ config X86_POWERNOW_K8
        tristate "AMD Opteron/Athlon64 PowerNow!"
        select CPU_FREQ_TABLE
        depends on EXPERIMENTAL
+       depends on X86_ACPI_CPUFREQ
        help
          This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.


             reply	other threads:[~2007-05-16  1:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16  1:17 Joshua Hoblitt [this message]
2007-05-16 14:55 ` Chuck Ebbert
2007-05-16 16:24 ` Dave Jones
2007-05-16 18:38 ` Prakash Punnoor
2007-05-16 19:53   ` Duane Griffin
2007-05-16 20:04     ` Daniel Drake
2007-05-16 21:27       ` Joshua Hoblitt
2007-05-16 22:39         ` Ed Sweetman
2007-05-16 23:18           ` Daniel Drake
2007-05-16 23:37             ` Ed Sweetman
2007-05-16 20:48     ` Dave Jones
2007-05-18  3:04       ` Joshua Hoblitt
2007-05-18  4:07         ` Ed Sweetman
2007-05-18  4:09         ` Ed Sweetman
2007-05-18 16:01           ` Dave Jones
2007-05-22  2:47             ` Joshua Hoblitt
2007-05-29 20:51               ` Dave Jones
2007-05-29 23:35                 ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070516011711.GE15763@ifa.hawaii.edu \
    --to=jhoblitt@ifa.hawaii.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®