mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
Cc: Ed Sweetman <safemode2@comcast.net>,
	Duane Griffin <duaneg@dghda.com>,
	Prakash Punnoor <prakash@punnoor.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Drake <dsd@gentoo.org>
Subject: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
Date: Tue, 29 May 2007 16:51:59 -0400	[thread overview]
Message-ID: <20070529205159.GA26124@redhat.com> (raw)
In-Reply-To: <20070522024743.GA21514@ifa.hawaii.edu>

On Mon, May 21, 2007 at 04:47:43PM -1000, Joshua Hoblitt wrote:

apologies for the delay in getting back to this.

 > Here is cleaned up version of Ed's patch that I believe addresses Dave's
 > stylistic concerns applies the relevant changes to both x86 & x86_64.

The x86-64 version is a symlink to the i386 file, so is unnecessary.
(That trap catches people out regularly).

 > Signed-off-by: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>

The patch content looks ok to me, Daniel, ack?


 > diff -Nurp linux-2.6.22-rc1-mm1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig l=
 > inux-2.6.22-rc1-mm1/arch/i386/kernel/cpu/cpufreq/Kconfig
 > --- linux-2.6.22-rc1-mm1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig  2007-04-=
 > 27 11:49:26.000000000 -1000
 > +++ linux-2.6.22-rc1-mm1/arch/i386/kernel/cpu/cpufreq/Kconfig   2007-05-21 16=
 > :20:47.000000000 -1000
 > @@ -90,10 +90,17 @@ config X86_POWERNOW_K8
 >       If in doubt, say N.
 > =20
 >  config X86_POWERNOW_K8_ACPI
 > -   bool
 > -   depends on X86_POWERNOW_K8 && ACPI_PROCESSOR
 > -   depends on !(X86_POWERNOW_K8 =3D y && ACPI_PROCESSOR =3D m)
 > +   bool "ACPI Support"

MIME damage prevents this from applying.

	Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-05-29 20:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16  1:17 Joshua Hoblitt
2007-05-16 14:55 ` Chuck Ebbert
2007-05-16 16:24 ` Dave Jones
2007-05-16 18:38 ` Prakash Punnoor
2007-05-16 19:53   ` Duane Griffin
2007-05-16 20:04     ` Daniel Drake
2007-05-16 21:27       ` Joshua Hoblitt
2007-05-16 22:39         ` Ed Sweetman
2007-05-16 23:18           ` Daniel Drake
2007-05-16 23:37             ` Ed Sweetman
2007-05-16 20:48     ` Dave Jones
2007-05-18  3:04       ` Joshua Hoblitt
2007-05-18  4:07         ` Ed Sweetman
2007-05-18  4:09         ` Ed Sweetman
2007-05-18 16:01           ` Dave Jones
2007-05-22  2:47             ` Joshua Hoblitt
2007-05-29 20:51               ` Dave Jones [this message]
2007-05-29 23:35                 ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070529205159.GA26124@redhat.com \
    --to=davej@redhat.com \
    --cc=dsd@gentoo.org \
    --cc=duaneg@dghda.com \
    --cc=jhoblitt@ifa.hawaii.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prakash@punnoor.de \
    --cc=safemode2@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome