mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
To: Dave Jones <davej@redhat.com>
Cc: Duane Griffin <duaneg@dghda.com>,
	Prakash Punnoor <prakash@punnoor.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Drake <dsd@gentoo.org>,
	Ed Sweetman <safemode2@comcast.net>
Subject: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
Date: Thu, 17 May 2007 17:04:36 -1000	[thread overview]
Message-ID: <20070518030436.GB20793@ifa.hawaii.edu> (raw)
In-Reply-To: <20070516204807.GA23751@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]

I think it's pretty clear that Dave and Daniel were both correct and
that ACPI_PROCESSOR is the correct dependency for multi-socket systems.
However, it's worth noting that this dependency seems to be unrelated to
SMP support.  Ed Sweetman has reported that his single-socket but
multi-core system doesn't require ACPI_PROCESSOR for powernow support.
I just tried booting 2.6.21 w/o SMP support and w/o ACPI_PROCESSOR on
one of my multi-socket/multi-core systems.  Sure enough, powernow 
won't work without ACPI_PROCESSOR:

powernow-k8: Found 1 Dual-Core AMD Opteron(tm) Processor 2220 processors (version 2.00.00)
powernow-k8: BIOS error - no PSB or ACPI _PSS objects

I suppose this means that the BIOS does something different to enable
SMP on a multi-core single socket and multi-socket systems.  Anyways, I
believe the question that needs to be answered is: is it reasonable for
X86_POWERNOW_K8 to select ACPI_PROCESSOR if SMP is set?  I'm not sure we
can do anything more intelligent unless Kconfig had more knowledge of
how the hardware other than just SMP/!SMP.

-J

--
On Wed, May 16, 2007 at 04:48:07PM -0400, Dave Jones wrote:
> On Wed, May 16, 2007 at 08:53:13PM +0100, Duane Griffin wrote:
>  > On 16/05/07, Prakash Punnoor <prakash@punnoor.de> wrote:
>  > > Maybe you want to give a hint in the p states driver help text?
>  > 
>  > I think a hint is the right thing to do, but in the PowerNow! driver
>  > rather than the p states one. How about adding something like this to
>  > the X86_POWERNOW_K8 (and X86_POWERNOW_K7?) help text:
> 
> The mobile K7s which had powernow support weren't SMP capable, so they're
> irrelevant.
> 
>  > "ACPI support is required for non-UP systems and requires ACPI_PROCESSOR
>  >  to be selected. If ACPI_PROCESSOR is compiled as a module then this
>  >  option must be too in order for ACPI support to be available."
> 
> X86_POWERNOW_K8_ACPI is already 'default y'. I think the problem lies in
> that people aren't enabling its dependancy, ACPI_PROCESSOR.
> 
> We want something along the lines of..
> 
> config X86_POWERNOW_K8_ACPI
> 	bool
> 	if SMP & X86_POWERNOW_K8_ACPI
> 	  select ACPI_PROCESSOR
> 
> kconfig language quirks aside..
> 
> 
> 	Dave
> 
> -- 
> http://www.codemonkey.org.uk

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-05-18  2:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16  1:17 Joshua Hoblitt
2007-05-16 14:55 ` Chuck Ebbert
2007-05-16 16:24 ` Dave Jones
2007-05-16 18:38 ` Prakash Punnoor
2007-05-16 19:53   ` Duane Griffin
2007-05-16 20:04     ` Daniel Drake
2007-05-16 21:27       ` Joshua Hoblitt
2007-05-16 22:39         ` Ed Sweetman
2007-05-16 23:18           ` Daniel Drake
2007-05-16 23:37             ` Ed Sweetman
2007-05-16 20:48     ` Dave Jones
2007-05-18  3:04       ` Joshua Hoblitt [this message]
2007-05-18  4:07         ` Ed Sweetman
2007-05-18  4:09         ` Ed Sweetman
2007-05-18 16:01           ` Dave Jones
2007-05-22  2:47             ` Joshua Hoblitt
2007-05-29 20:51               ` Dave Jones
2007-05-29 23:35                 ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070518030436.GB20793@ifa.hawaii.edu \
    --to=jhoblitt@ifa.hawaii.edu \
    --cc=davej@redhat.com \
    --cc=dsd@gentoo.org \
    --cc=duaneg@dghda.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prakash@punnoor.de \
    --cc=safemode2@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®