From: Jakob Oestergaard <jakob@unthought.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Frank van Maarseveen <frankvm@frankvm.com>,
Hua Zhong <hzhong@gmail.com>,
"'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org
Subject: Re: recent nfs change causes autofs regression
Date: Fri, 31 Aug 2007 09:40:28 +0200 [thread overview]
Message-ID: <20070831074028.GR21979@unthought.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0708302215280.25853@woody.linux-foundation.org>
On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote:
>
...
> > Why aren't we doing that for any other filesystem than NFS?
>
> How hard is it to acknowledge the following little word:
>
> "regression"
>
> It's simple. You broke things. You may want to fix them, but you need to
> fix them in a way that does not break user space.
Trond has a point Linus.
What he "broke" is, for example, a ro mount being mounted as rw.
That *could* be a very serious security (etc.etc.) problem which he just fixed.
Anything depending on read-only not being enforced will cease to work, of
course, and that is what a few people complain about(!).
If ext3 in some rare case (which would still mean it hit a few thousand users)
failed to remember that a file had been marked read-only and allowed writes to
it, wouldn't we want to fix that too? It would cause regressions, but we'd fix
it, right?
mount passes back the error code on a failed mount. autofs passes that error
along too (when people configure syslog correctly). In short; when these
serious mistakes are made and caught, the admin sees an error in his logs.
This is not wrong. This is good.
--
/ jakob
next prev parent reply other threads:[~2007-08-31 7:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 21:07 Hua Zhong
2007-08-30 22:37 ` Trond Myklebust
2007-08-30 22:47 ` Hua Zhong
2007-08-30 23:22 ` Trond Myklebust
2007-08-30 23:30 ` Hua Zhong
2007-08-30 23:37 ` Trond Myklebust
2007-08-30 23:44 ` Hua Zhong
2007-08-31 4:31 ` Trond Myklebust
2007-08-31 4:38 ` Linus Torvalds
2007-08-31 4:47 ` Hua Zhong
2007-08-31 4:57 ` Trond Myklebust
2007-08-31 5:09 ` Ian Kent
2007-08-31 7:50 ` Matthias Schniedermeyer
2007-08-31 1:24 ` Andrew Morton
2007-08-31 4:33 ` Trond Myklebust
2007-08-31 3:49 ` Linus Torvalds
2007-08-31 3:57 ` Hua Zhong
2007-08-31 4:44 ` Trond Myklebust
2007-08-31 4:59 ` Linus Torvalds
2007-08-31 5:04 ` Trond Myklebust
2007-08-31 5:16 ` Linus Torvalds
2007-08-31 7:40 ` Jakob Oestergaard [this message]
2007-08-31 8:07 ` Linus Torvalds
2007-08-31 8:51 ` Jakob Oestergaard
2007-08-31 16:43 ` Linus Torvalds
2007-09-03 13:20 ` Jakob Oestergaard
2007-09-03 13:43 ` Martin Knoblauch
2007-08-31 12:11 ` Trond Myklebust
2007-08-31 13:12 ` Frank van Maarseveen
2007-08-31 13:50 ` Trond Myklebust
2007-08-31 14:42 ` Frank van Maarseveen
2007-09-04 7:51 ` David Howells
2007-08-31 8:28 ` Frank van Maarseveen
2007-08-31 5:24 ` Hua Zhong
2007-08-31 5:38 ` Ian Kent
2007-08-31 8:54 ` Martin Knoblauch
2007-08-31 16:21 ` Trond Myklebust
2007-08-31 17:01 ` Linus Torvalds
2007-08-31 19:03 ` Trond Myklebust
2007-08-31 18:47 ` Hua Zhong
2007-08-31 19:13 ` Trond Myklebust
2007-08-31 19:35 ` Hua Zhong
2007-08-31 19:41 ` Hua Zhong
2007-09-02 0:58 ` Bill Davidsen
2007-09-04 7:54 ` David Howells
2007-09-05 12:35 ` Bill Davidsen
2007-09-05 12:44 ` Ian Kent
2007-09-05 16:26 ` Trond Myklebust
2007-09-05 15:34 ` David Howells
2007-09-05 15:37 ` David Howells
2007-09-05 15:50 ` Trond Myklebust
2007-09-06 5:23 ` Ian Kent
2007-09-04 8:02 ` David Howells
2007-09-04 8:35 ` David Howells
2007-09-04 9:04 ` Linus Torvalds
2007-08-31 8:14 ` Frank van Maarseveen
2007-08-31 9:05 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831074028.GR21979@unthought.net \
--to=jakob@unthought.net \
--cc=akpm@linux-foundation.org \
--cc=frankvm@frankvm.com \
--cc=hzhong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome