From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Brett Warden" <brett.warden@gmail.com>
Cc: "Ray Lee" <ray-lk@madrabbit.org>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register
Date: Thu, 27 Sep 2007 22:29:34 +0100 [thread overview]
Message-ID: <20070927222934.010f1898@the-village.bc.nu> (raw)
In-Reply-To: <a372714f0709271228r7de8a4a0p4c5d75e939513f08@mail.gmail.com>
On Thu, 27 Sep 2007 12:28:31 -0700
"Brett Warden" <brett.warden@gmail.com> wrote:
> Fixes use of parport_write_control() to match the newer interface that
> requires explicit parport_data_reverse() and parport_data_forward()
> calls. This eliminates the following error message and restores the
> original intended behavior:
Looks good
> parport0 (bw-qcam): use data_reverse for this!
>
> Also increases threshold in qc_detect() from 300 to 400, as my camera
> often results in a count of approx 330. Added a kernel error message
> to indicate detection failure.
Likewise
> Signed-off-by: Brett T. Warden <brett.warden@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2007-09-27 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 19:12 Brett Warden
2007-09-26 19:43 ` Ray Lee
2007-09-26 20:06 ` Brett Warden
2007-09-26 21:00 ` Ray Lee
2007-09-26 21:43 ` Brett Warden
2007-09-27 19:28 ` Brett Warden
2007-09-27 21:29 ` Alan Cox [this message]
2007-09-26 21:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927222934.010f1898@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=brett.warden@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=ray-lk@madrabbit.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®