From: "Brett Warden" <brett.warden@gmail.com>
To: "Ray Lee" <ray-lk@madrabbit.org>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register
Date: Wed, 26 Sep 2007 13:06:59 -0700 [thread overview]
Message-ID: <a372714f0709261306q714100e3t643b31d8f194de2e@mail.gmail.com> (raw)
In-Reply-To: <2c0942db0709261243h1267140br70796c7fcfb165e3@mail.gmail.com>
On 9/26/07, Ray Lee <ray-lk@madrabbit.org> wrote:
> Just as an aside, if you've tested this and it works, then there's no
> point to keep the write_lpcontrol even as a comment. Kill those four
> lines, and if someone's interested in what happened they'll just look
> at the file history.
Point taken, thanks for the feedback.
---
diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c
index 7d47cbe..0ba92e3 100644
--- a/drivers/media/video/bw-qcam.c
+++ b/drivers/media/video/bw-qcam.c
@@ -107,6 +107,11 @@ static inline void write_lpcontrol(struct
qcam_device *q, int d)
parport_write_control(q->pport, d);
}
+static inline void reverse_port(struct qcam_device *q)
+{
+ parport_data_reverse(q->pport);
+}
+
static int qc_waithand(struct qcam_device *q, int val);
static int qc_command(struct qcam_device *q, int command);
static int qc_readparam(struct qcam_device *q);
@@ -369,7 +374,7 @@ static void qc_reset(struct qcam_device *q)
break;
case QC_ANY:
- write_lpcontrol(q, 0x20);
+ reverse_port(q);
write_lpdata(q, 0x75);
if (read_lpdata(q) != 0x75) {
@@ -512,10 +517,12 @@ static inline int qc_readbytes(struct
qcam_device *q, char buffer[])
switch (q->port_mode & QC_MODE_MASK)
{
case QC_BIDIR: /* Bi-directional Port */
- write_lpcontrol(q, 0x26);
+ reverse_port(q);
+ write_lpcontrol(q, 0x6);
lo = (qc_waithand2(q, 1) >> 1);
hi = (read_lpstatus(q) >> 3) & 0x1f;
- write_lpcontrol(q, 0x2e);
+ reverse_port(q);
+ write_lpcontrol(q, 0xe);
lo2 = (qc_waithand2(q, 0) >> 1);
hi2 = (read_lpstatus(q) >> 3) & 0x1f;
switch (q->bpp)
@@ -613,10 +620,13 @@ static long qc_capture(struct qcam_device * q,
char __user *buf, unsigned long l
if ((q->port_mode & QC_MODE_MASK) == QC_BIDIR)
{
- write_lpcontrol(q, 0x2e); /* turn port around */
- write_lpcontrol(q, 0x26);
+ reverse_port(q); /* turn port around */
+ write_lpcontrol(q, 0xe);
+ reverse_port(q);
+ write_lpcontrol(q, 0x6);
(void) qc_waithand(q, 1);
- write_lpcontrol(q, 0x2e);
+ reverse_port(q);
+ write_lpcontrol(q, 0xe);
(void) qc_waithand(q, 0);
}
--
Brett Warden
next prev parent reply other threads:[~2007-09-26 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 19:12 Brett Warden
2007-09-26 19:43 ` Ray Lee
2007-09-26 20:06 ` Brett Warden [this message]
2007-09-26 21:00 ` Ray Lee
2007-09-26 21:43 ` Brett Warden
2007-09-27 19:28 ` Brett Warden
2007-09-27 21:29 ` Alan Cox
2007-09-26 21:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a372714f0709261306q714100e3t643b31d8f194de2e@mail.gmail.com \
--to=brett.warden@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ray-lk@madrabbit.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®