From: "Ray Lee" <ray-lk@madrabbit.org>
To: "Brett Warden" <brett.warden@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register
Date: Wed, 26 Sep 2007 12:43:08 -0700 [thread overview]
Message-ID: <2c0942db0709261243h1267140br70796c7fcfb165e3@mail.gmail.com> (raw)
In-Reply-To: <a372714f0709261212hec0c61ofc5dd6d127352402@mail.gmail.com>
On 9/26/07, Brett Warden <brett.warden@gmail.com> wrote:
> Appeases the warning "parport0 (bw-qcam): use data_reverse for this!"
>
> Signed-off-by: Brett T. Warden <brett.warden@gmail.com>
>
> ---
>
> It seems to work fine with my Quickcam under 2.6.22.
> @@ -369,7 +374,11 @@ static void qc_reset(struct qcam_device *q)
> break;
>
> case QC_ANY:
> - write_lpcontrol(q, 0x20);
> + /*
> + * Replaced with reverse_port
> + * write_lpcontrol(q, 0x20);
> + */
> + reverse_port(q);
> write_lpdata(q, 0x75);
>
> if (read_lpdata(q) != 0x75) {
Just as an aside, if you've tested this and it works, then there's no
point to keep the write_lpcontrol even as a comment. Kill those four
lines, and if someone's interested in what happened they'll just look
at the file history.
Ray
next prev parent reply other threads:[~2007-09-26 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 19:12 Brett Warden
2007-09-26 19:43 ` Ray Lee [this message]
2007-09-26 20:06 ` Brett Warden
2007-09-26 21:00 ` Ray Lee
2007-09-26 21:43 ` Brett Warden
2007-09-27 19:28 ` Brett Warden
2007-09-27 21:29 ` Alan Cox
2007-09-26 21:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0942db0709261243h1267140br70796c7fcfb165e3@mail.gmail.com \
--to=ray-lk@madrabbit.org \
--cc=brett.warden@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®