Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

[Alan Cox]

On Thu, 1 Nov 2007 19:59:25 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:

> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=49259d34c52df6be482fefca946debe28ba9a2f6
> Commit:     49259d34c52df6be482fefca946debe28ba9a2f6
> Parent:     3b582cc14c50f71eabf1c3cada05acb8dc9f457c
> Author:     David S. Miller <davem@sunset.davemloft.net>
> AuthorDate: Thu Nov 1 02:26:38 2007 -0700
> Committer:  David S. Miller <davem@sunset.davemloft.net>
> CommitDate: Thu Nov 1 02:26:38 2007 -0700
> 
>     [IRDA] IRNET: Fix build when TCGETS2 is defined.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>

NO NO NO NO NO NO NO

Line disciplines have no business touching termios ioctls. Especially
wrongly. 

Nothing anywhere in the kernel but the core ioctl code should be
processing TCGET/TCSET calls.

Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
process them.

Alan

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 1 Nov 2007 22:30:10 +0000

> NO NO NO NO NO NO NO

Glad that got your attention, finally...

> Line disciplines have no business touching termios ioctls. Especially
> wrongly. 
> 
> Nothing anywhere in the kernel but the core ioctl code should be
> processing TCGET/TCSET calls.
> 
> Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
> process them.

Ok.

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

[Alan Cox]

> > Nothing anywhere in the kernel but the core ioctl code should be
> > processing TCGET/TCSET calls.
> > 
> > Just delete them. It will return -ENOIOCTLCMD and the core tty layer will
> > process them.
> 
> Ok.

One set of patches in testing.

For the irda non-tty device its almost impossible to hack up a sane
solution except to delete the junk. pppd has supported "notty" for some
years so there is no excuse for that still being present.

The ones with actual ttys can be done cleanly so I've

- split n_tty_ioctl
- used the split to create tty_mode_ioctl() which an ldisc can use for
generic mode handling
- extracted the flush method so it can be used more cleanly by ppp etc

Patches to follow shortly for review

Alan

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

[Alan Cox]

I'll go split the n_tty_ioctl stuff up and sort this cleanly for the
serial ppp and other users as well.  Will send a patch tomorrow that
makes ldisc catching of TCGET/SET calls unneccessary.

Alan

Re: [IRDA] IRNET: Fix build when TCGETS2 is defined.

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 1 Nov 2007 22:32:53 +0000

[ davem@redhat.com is not my upstream email address, please don't
  use it for public discussions, thank you ]

> I'll go split the n_tty_ioctl stuff up and sort this cleanly for the
> serial ppp and other users as well.  Will send a patch tomorrow that
> makes ldisc catching of TCGET/SET calls unneccessary.

Thanks.

Please also do something with the x86/termios.h patch I sent you as
well, it will prevent these kind of boo-boos in the future.