From: Sam Ravnborg <sam@ravnborg.org>
To: David Brownell <david-b@pacbell.net>
Cc: Ingo Molnar <mingo@elte.hu>, Pavel Machek <pavel@ucw.cz>,
linux-pm@lists.linux-foundation.org,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] sleepy linux self-test
Date: Sun, 3 Feb 2008 08:51:11 +0100 [thread overview]
Message-ID: <20080203075111.GB19981@uranus.ravnborg.org> (raw)
In-Reply-To: <200802022318.03597.david-b@pacbell.net>
> --- g26.orig/drivers/char/Kconfig
> +++ g26/drivers/char/Kconfig
> @@ -715,9 +715,12 @@ config NVRAM
> To compile this driver as a module, choose M here: the
> module will be called nvram.
>
> +comment "You are using the RTC framework, not the legacy CMOS RTC driver"
> + depends on RTC_DRV_CMOS
> +
> config RTC
> tristate "Enhanced Real Time Clock Support"
> - depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV && !ARM && !SUPERH && !S390
> + depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV && !ARM && !SUPERH && !S390 && !RTC_DRV_CMOS
This looks like a prime candidate for a HAVE_RTC config variable
So you do:
config RTC
tristate "Enhanced Real Time Clock Support"
+ depends on HAVE_RTC && !RTC_DEV_CMOS
config HAVE_RTC
bool
(No "depends on" allowed!)
And then the architectures that do support the RTC Framework do an:
(arch/x86/Kconfig as an example):
config X86
+ select HAVE_RTC
So when PPC suddenly supports it they add this single
select statement and no more Kconfig magic needed.
See Documentation/kbuild/kconfig-language.txt for a bit more elaborate
description.
Sam
next prev parent reply other threads:[~2008-02-03 7:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 13:17 Pavel Machek
2008-01-30 16:35 ` Ingo Molnar
2008-01-30 16:39 ` Pavel Machek
2008-01-30 19:36 ` Ingo Molnar
2008-01-30 23:26 ` Pavel Machek
2008-02-01 14:22 ` Ingo Molnar
2008-02-02 12:45 ` Pavel Machek
2008-02-02 13:49 ` Ingo Molnar
2008-02-02 13:51 ` Ingo Molnar
2008-02-01 1:55 ` [linux-pm] " David Brownell
2008-02-02 12:47 ` Pavel Machek
2008-02-02 13:50 ` Ingo Molnar
2008-02-02 17:49 ` David Brownell
2008-02-02 18:06 ` Ingo Molnar
2008-02-02 19:47 ` David Brownell
2008-02-02 17:31 ` David Brownell
2008-02-02 17:51 ` David Brownell
2008-02-02 18:00 ` Ingo Molnar
2008-02-02 19:13 ` David Brownell
2008-02-02 19:32 ` Pavel Machek
2008-02-02 19:38 ` Ingo Molnar
2008-02-02 19:59 ` Pavel Machek
2008-02-03 2:37 ` David Brownell
2008-02-03 5:05 ` Ingo Molnar
2008-02-03 5:14 ` Ingo Molnar
2008-02-03 5:19 ` Ingo Molnar
2008-02-03 5:35 ` Ingo Molnar
2008-02-03 5:54 ` Ingo Molnar
2008-02-03 7:05 ` Ingo Molnar
2008-02-03 7:32 ` David Brownell
2008-02-03 12:21 ` Rafael J. Wysocki
2008-02-03 13:16 ` David Brownell
2008-02-03 21:29 ` Rafael J. Wysocki
2008-02-03 22:42 ` David Brownell
2008-02-03 22:43 ` Rafael J. Wysocki
2008-02-03 22:48 ` Pavel Machek
2008-02-03 23:08 ` David Brownell
2008-02-10 21:03 ` Pavel Machek
2008-02-18 8:56 ` Pavel Machek
2008-02-18 9:46 ` [patch] suspend/resume self-test Ingo Molnar
2008-02-18 9:53 ` Pavel Machek
2008-02-18 10:40 ` David Brownell
2008-02-18 11:04 ` Rafael J. Wysocki
2008-02-18 13:09 ` Ingo Molnar
2008-02-18 20:16 ` David Brownell
2008-02-19 10:11 ` Pavel Machek
2008-02-19 14:43 ` Ingo Molnar
2008-02-19 19:12 ` David Brownell
2008-02-20 10:15 ` Ingo Molnar
2008-02-19 14:40 ` Ingo Molnar
2008-02-18 11:06 ` Rafael J. Wysocki
2008-02-10 21:02 ` [linux-pm] sleepy linux self-test Pavel Machek
2008-02-03 7:18 ` David Brownell
2008-02-03 7:51 ` Sam Ravnborg [this message]
2008-02-03 8:26 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203075111.GB19981@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®