From: David Brownell <david-b@pacbell.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pavel Machek <pavel@ucw.cz>,
rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch] suspend/resume self-test
Date: Tue, 19 Feb 2008 11:12:57 -0800 [thread overview]
Message-ID: <200802191112.57616.david-b@pacbell.net> (raw)
In-Reply-To: <20080219144328.GD21176@elte.hu>
On Tuesday 19 February 2008, Ingo Molnar wrote:
> * Pavel Machek <pavel@ucw.cz> wrote:
>
> > > Thing is, this will catch not just regressions ... but cases where
> > > STR never worked in the first place. Video problems, etc. Also
> > > various system startup races, as in the PCMCIA and MMC/SD/SDIO cases
> > > I noted.
> >
> > David is right here. At minimum, s2ram needs acpi_sleep=... options to
> > tell it how to set up the video. That is not issue for you, but it
> > means we should not be doing it by default.
>
> nowhere did i suggest that it should be default-enabled ...
The patch you asked to be merged *DID* have it be default-enabled!
So you did more than just "suggest"... if that option is enabled in
Kconfig, this test is always forced on and it will cause failures
on systems where STR has never worked.
The patch comments even pointed out that flaw.
next prev parent reply other threads:[~2008-02-19 19:13 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 13:17 sleepy linux self-test Pavel Machek
2008-01-30 16:35 ` Ingo Molnar
2008-01-30 16:39 ` Pavel Machek
2008-01-30 19:36 ` Ingo Molnar
2008-01-30 23:26 ` Pavel Machek
2008-02-01 14:22 ` Ingo Molnar
2008-02-02 12:45 ` Pavel Machek
2008-02-02 13:49 ` Ingo Molnar
2008-02-02 13:51 ` Ingo Molnar
2008-02-01 1:55 ` [linux-pm] " David Brownell
2008-02-02 12:47 ` Pavel Machek
2008-02-02 13:50 ` Ingo Molnar
2008-02-02 17:49 ` David Brownell
2008-02-02 18:06 ` Ingo Molnar
2008-02-02 19:47 ` David Brownell
2008-02-02 17:31 ` David Brownell
2008-02-02 17:51 ` David Brownell
2008-02-02 18:00 ` Ingo Molnar
2008-02-02 19:13 ` David Brownell
2008-02-02 19:32 ` Pavel Machek
2008-02-02 19:38 ` Ingo Molnar
2008-02-02 19:59 ` Pavel Machek
2008-02-03 2:37 ` David Brownell
2008-02-03 5:05 ` Ingo Molnar
2008-02-03 5:14 ` Ingo Molnar
2008-02-03 5:19 ` Ingo Molnar
2008-02-03 5:35 ` Ingo Molnar
2008-02-03 5:54 ` Ingo Molnar
2008-02-03 7:05 ` Ingo Molnar
2008-02-03 7:32 ` David Brownell
2008-02-03 12:21 ` Rafael J. Wysocki
2008-02-03 13:16 ` David Brownell
2008-02-03 21:29 ` Rafael J. Wysocki
2008-02-03 22:42 ` David Brownell
2008-02-03 22:43 ` Rafael J. Wysocki
2008-02-03 22:48 ` Pavel Machek
2008-02-03 23:08 ` David Brownell
2008-02-10 21:03 ` Pavel Machek
2008-02-18 8:56 ` Pavel Machek
2008-02-18 9:46 ` [patch] suspend/resume self-test Ingo Molnar
2008-02-18 9:53 ` Pavel Machek
2008-02-18 10:40 ` David Brownell
2008-02-18 11:04 ` Rafael J. Wysocki
2008-02-18 13:09 ` Ingo Molnar
2008-02-18 20:16 ` David Brownell
2008-02-19 10:11 ` Pavel Machek
2008-02-19 14:43 ` Ingo Molnar
2008-02-19 19:12 ` David Brownell [this message]
2008-02-20 10:15 ` Ingo Molnar
2008-02-19 14:40 ` Ingo Molnar
2008-02-18 11:06 ` Rafael J. Wysocki
2008-02-10 21:02 ` [linux-pm] sleepy linux self-test Pavel Machek
2008-02-03 7:18 ` David Brownell
2008-02-03 7:51 ` Sam Ravnborg
2008-02-03 8:26 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802191112.57616.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®