From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Merge setup_32/64.c into setup.c
Date: Wed, 25 Jun 2008 18:43:00 +0200 [thread overview]
Message-ID: <20080625164300.GC6040@elte.hu> (raw)
In-Reply-To: <86802c440806250844s51b50311va1c8e9c9fc1da510@mail.gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> >> include/asm-x86/setup.h | 2
> >> 5 files changed, 670 insertions(+), 934 deletions(-)
> >
> > very nice!
> >
> > could we please split this up into several, gradual steps that bring
> > setup_32.c and setup_64.c to exactly the same content - where the final
> > patch just renames arch/x86/kernel/setup_32.c to arch/x86/kernel/setup.c
> > and deletes arch/x86/kernel/setup_64.c ?
>
> OK, someone (Mike Triavis) already stole setup.c for X86_NUMA.
>
> You need to change that setup.c to other name. or split it away...
hm, that change was supposed to be the seed of a unification. So if it
actually hinders you, feel free to move it to a different file.
Obviously it is setup_32.c and setup_64.c that should be unified into
setup.c.
Ingo
next prev parent reply other threads:[~2008-06-25 16:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 5:13 [PATCH] x86: numa 32 using apicid_2_node to get node for logical_apicid Yinghai Lu
2008-06-25 5:14 ` [PATCH] x86: remove end_pfn in 64bit Yinghai Lu
2008-06-25 8:14 ` [PATCH] x86: Merge setup_32/64.c into setup.c Yinghai Lu
2008-06-25 15:36 ` Ingo Molnar
2008-06-25 15:44 ` Yinghai Lu
2008-06-25 16:43 ` Ingo Molnar [this message]
2008-06-25 17:28 ` Yinghai Lu
2008-06-25 17:38 ` Mike Travis
2008-06-25 17:46 ` Yinghai Lu
2008-06-25 17:48 ` H. Peter Anvin
2008-06-25 15:41 ` [PATCH] x86: remove end_pfn in 64bit Ingo Molnar
2008-06-25 21:31 ` Jeremy Fitzhardinge
2008-06-25 21:57 ` Yinghai Lu
2008-06-25 22:21 ` Jeremy Fitzhardinge
2008-06-25 23:14 ` Yinghai Lu
2008-06-25 23:16 ` Jeremy Fitzhardinge
2008-06-26 10:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625164300.GC6040@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome