mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: remove end_pfn in 64bit
Date: Wed, 25 Jun 2008 16:14:54 -0700	[thread overview]
Message-ID: <86802c440806251614t68ec7bf9o8f39b8c31b245977@mail.gmail.com> (raw)
In-Reply-To: <4862C4DA.9060004@goop.org>

On Wed, Jun 25, 2008 at 3:21 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Yinghai Lu wrote:
>>
>> On Wed, Jun 25, 2008 at 2:31 PM, Jeremy Fitzhardinge <jeremy@goop.org>
>> wrote:
>>
>>>
>>> Ingo Molnar wrote:
>>>
>>>>
>>>> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>>>>
>>>>
>>>>
>>>>>
>>>>> and use max_pfn directly.
>>>>>
>>>>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>>>>>
>>>>>
>>>>
>>>> applied to tip/x86/setup-memory - thanks Yinghai. I have picked up these
>>>> patches:
>>>>
>>>> Ingo Molnar (1):
>>>>     Merge branch 'x86/setup-memory'
>>>>
>>>> Yinghai Lu (6):
>>>>     x86: fix e820_update_range size when overlapping
>>>>     x86: get max_pfn_mapped in init_memory_mapping
>>>>     x86: add table_top check for alloc_low_page in 64 bit
>>>>     x86: change size if e820_update/remove_range
>>>>     x86: numa 32 using apicid_2_node to get node for logical_apicid
>>>>     x86: remove end_pfn in 64bit
>>>>
>>>>
>>>
>>> Did you CC: this to me to indicate that "x86_64: replace end_pfn with
>>> num_physpages" conflicts massively with this patch?  Fortunately I don't
>>> depend on it, so I don't mind much.
>>>
>>> How does "max_pfn" differ from "num_physpages"?  Should one of them go as
>>> well?
>>>
>>
>> 64bit setup_arch assign num_physpages with end_pfn...
>>
>
> I posted a patch to remove end_pfn and replace it with num_physpages
> everywhere, which obviously clashed badly with your patch ;)

32bit has max_pfn, max_low_pfn, max_pfn_mapped...and min_low_pfn.

>
>> and max_pfn is defined in linux/bootmem.h
>> num_physpages  is defined in linux/mm.h
>
> Do they contain separate values?  Do they mean different things?

x86 64 bit that they are same. num_phypages = max_pfn
32 bit when HIGHMEM=y, it is same.num_phypages = max_pfn
         when HIGHMEM=n, num_phypages = max_low_pfn

YH

  reply	other threads:[~2008-06-25 23:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  5:13 [PATCH] x86: numa 32 using apicid_2_node to get node for logical_apicid Yinghai Lu
2008-06-25  5:14 ` [PATCH] x86: remove end_pfn in 64bit Yinghai Lu
2008-06-25  8:14   ` [PATCH] x86: Merge setup_32/64.c into setup.c Yinghai Lu
2008-06-25 15:36     ` Ingo Molnar
2008-06-25 15:44       ` Yinghai Lu
2008-06-25 16:43         ` Ingo Molnar
2008-06-25 17:28           ` Yinghai Lu
2008-06-25 17:38             ` Mike Travis
2008-06-25 17:46               ` Yinghai Lu
2008-06-25 17:48                 ` H. Peter Anvin
2008-06-25 15:41   ` [PATCH] x86: remove end_pfn in 64bit Ingo Molnar
2008-06-25 21:31     ` Jeremy Fitzhardinge
2008-06-25 21:57       ` Yinghai Lu
2008-06-25 22:21         ` Jeremy Fitzhardinge
2008-06-25 23:14           ` Yinghai Lu [this message]
2008-06-25 23:16             ` Jeremy Fitzhardinge
2008-06-26 10:04       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440806251614t68ec7bf9o8f39b8c31b245977@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®