From: Yu Zhao <yu.zhao@intel.com>
To: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "achiang@hp.com" <achiang@hp.com>,
"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
"greg@kroah.com" <greg@kroah.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"matthew@wil.cx" <matthew@wil.cx>,
"randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
"rdreier@cisco.com" <rdreier@cisco.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: [PATCH 5/16 v6] PCI: add a wrapper for resource_alignment()
Date: Wed, 22 Oct 2008 16:41:48 +0800 [thread overview]
Message-ID: <20081022084148.GE3773@yzhao12-linux.sh.intel.com> (raw)
In-Reply-To: <20081022083809.GA3757@yzhao12-linux.sh.intel.com>
Add a wrapper for resource_alignment() so it can handle device specific
resource alignment.
Cc: Alex Chiang <achiang@hp.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Yu Zhao <yu.zhao@intel.com>
---
drivers/pci/pci.c | 20 ++++++++++++++++++++
drivers/pci/pci.h | 1 +
drivers/pci/setup-bus.c | 4 ++--
drivers/pci/setup-res.c | 7 ++++---
4 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 40284dc..a9b554e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1904,6 +1904,26 @@ int pci_select_bars(struct pci_dev *dev, unsigned long flags)
return bars;
}
+/**
+ * pci_resource_alignment - get a PCI BAR resource alignment
+ * @dev: the PCI device
+ * @resno: the resource number
+ *
+ * Returns alignment size on success, or 0 on error.
+ */
+int pci_resource_alignment(struct pci_dev *dev, int resno)
+{
+ resource_size_t align;
+ struct resource *res = dev->resource + resno;
+
+ align = resource_alignment(res);
+ if (align)
+ return align;
+
+ dev_err(&dev->dev, "alignment: invalid resource #%d\n", resno);
+ return 0;
+}
+
static void __devinit pci_no_domains(void)
{
#ifdef CONFIG_PCI_DOMAINS
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index fbbc6ad..baa3d23 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -166,6 +166,7 @@ enum pci_bar_type {
extern int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
struct resource *res, unsigned int reg);
+extern int pci_resource_alignment(struct pci_dev *dev, int resno);
extern void pci_enable_ari(struct pci_dev *dev);
/**
* pci_ari_enabled - query ARI forwarding status
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index ea979f2..90a9c0a 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -25,6 +25,7 @@
#include <linux/ioport.h>
#include <linux/cache.h>
#include <linux/slab.h>
+#include "pci.h"
static void pbus_assign_resources_sorted(struct pci_bus *bus)
@@ -351,8 +352,7 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, unsigned long
if (r->parent || (r->flags & mask) != type)
continue;
r_size = resource_size(r);
- /* For bridges size != alignment */
- align = resource_alignment(r);
+ align = pci_resource_alignment(dev, i);
order = __ffs(align) - 20;
if (order > 11) {
dev_warn(&dev->dev, "BAR %d bad alignment %llx: "
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index b7ca679..88a9c70 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -133,7 +133,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
size = resource_size(res);
min = (res->flags & IORESOURCE_IO) ? PCIBIOS_MIN_IO : PCIBIOS_MIN_MEM;
- align = resource_alignment(res);
+ align = pci_resource_alignment(dev, resno);
if (!align) {
dev_err(&dev->dev, "BAR %d: can't allocate resource (bogus "
"alignment) %pR flags %#lx\n",
@@ -224,7 +224,7 @@ void pdev_sort_resources(struct pci_dev *dev, struct resource_list *head)
if (!(r->flags) || r->parent)
continue;
- r_align = resource_alignment(r);
+ r_align = pci_resource_alignment(dev, i);
if (!r_align) {
dev_warn(&dev->dev, "BAR %d: bogus alignment "
"%pR flags %#lx\n",
@@ -236,7 +236,8 @@ void pdev_sort_resources(struct pci_dev *dev, struct resource_list *head)
struct resource_list *ln = list->next;
if (ln)
- align = resource_alignment(ln->res);
+ align = pci_resource_alignment(ln->dev,
+ ln->res - ln->dev->resource);
if (r_align > align) {
tmp = kmalloc(sizeof(*tmp), GFP_KERNEL);
--
1.5.6.4
next prev parent reply other threads:[~2008-10-22 9:37 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 8:38 [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Yu Zhao
2008-10-22 8:40 ` [PATCH 1/16 v6] PCI: remove unnecessary arg of pci_update_resource() Yu Zhao
2008-10-22 8:40 ` [PATCH 2/16 v6] PCI: define PCI resource names in an 'enum' Yu Zhao
2008-10-22 14:24 ` Bjorn Helgaas
2008-10-22 14:44 ` Yu Zhao
2008-10-22 14:51 ` Bjorn Helgaas
2008-10-22 14:53 ` Yu Zhao
2008-11-14 0:43 ` Simon Horman
2008-10-22 8:41 ` [PATCH 3/16 v6] PCI: export __pci_read_base Yu Zhao
2008-10-22 8:41 ` [PATCH 4/16 v6] PCI: make pci_alloc_child_bus() be able to handle NULL bridge Yu Zhao
2008-10-22 8:41 ` Yu Zhao [this message]
2008-10-22 8:42 ` [PATCH 6/16 v6] PCI: add a new function to map BAR offset Yu Zhao
2008-10-22 8:42 ` [PATCH 7/16 v6] PCI: cleanup pcibios_allocate_resources() Yu Zhao
2008-10-23 7:10 ` Yinghai Lu
2008-10-23 6:50 ` Yu Zhao
2008-10-22 8:43 ` [PATCH 8/16 v6] PCI: add boot options to reassign resources Yu Zhao
2008-10-22 14:35 ` Bjorn Helgaas
2008-10-22 14:49 ` Yu Zhao
2008-10-22 8:43 ` [PATCH 9/16 v6] PCI: add boot option to align MMIO resources Yu Zhao
2008-10-22 14:34 ` Bjorn Helgaas
2008-10-22 14:52 ` Yu Zhao
2008-10-22 8:43 ` [PATCH 10/16 v6] PCI: cleanup pci_bus_add_devices() Yu Zhao
2008-10-22 8:44 ` [PATCH 11/16 v6] PCI: split a new function from pci_bus_add_devices() Yu Zhao
2008-10-22 8:44 ` [PATCH 12/16 v6] PCI: support the SR-IOV capability Yu Zhao
2008-10-22 8:44 ` [PATCH 13/16 v6] PCI: reserve bus range for SR-IOV device Yu Zhao
2008-10-22 8:45 ` [PATCH 14/16 v6] PCI: document for SR-IOV user and developer Yu Zhao
2008-10-22 8:45 ` [PATCH 15/16 v6] PCI: document the SR-IOV sysfs entries Yu Zhao
2008-11-06 4:33 ` Greg KH
2008-11-06 4:46 ` Greg KH
2008-11-07 3:01 ` Zhao, Yu
2008-11-07 3:18 ` Greg KH
2008-11-13 6:50 ` Yu Zhao
2008-11-14 0:55 ` Greg KH
2008-11-17 8:09 ` Yu Zhao
2008-11-18 15:05 ` Greg KH
2008-11-18 16:49 ` Kay Sievers
2008-10-22 8:45 ` [PATCH 16/16 v6] PCI: document the new PCI boot parameters Yu Zhao
2008-10-22 14:27 ` Bjorn Helgaas
2008-10-22 17:01 ` Randy Dunlap
2008-11-06 4:32 ` Greg KH
2008-11-07 2:37 ` Zhao, Yu
2008-11-07 2:50 ` Greg KH
2008-11-07 3:40 ` Zhao, Yu
2008-11-07 4:17 ` Matthew Wilcox
2008-12-11 1:43 ` Yu Zhao
2008-12-11 4:33 ` Grant Grundler
2008-12-11 15:39 ` H L
2008-11-07 6:16 ` Greg KH
2008-11-07 7:50 ` Zhao, Yu
2008-11-07 8:02 ` Greg KH
2008-11-07 8:17 ` Zhao, Yu
2008-11-07 8:24 ` Greg KH
2008-11-07 8:35 ` Zhao, Yu
2008-11-07 18:53 ` Greg KH
2008-11-08 5:00 ` Yu Zhao
2008-11-08 5:25 ` Greg KH
2008-11-08 6:05 ` Yu Zhao
[not found] ` <fe8256d20811072150o1d82e8bdq40bf61df0a3faebe@mail.gmail.com>
2008-11-08 5:54 ` Greg KH
2008-11-09 14:19 ` Pavel Machek
2008-11-09 14:34 ` Alexander Graf
2008-11-06 4:48 ` [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Greg KH
2008-11-06 15:40 ` H L
2008-11-06 15:43 ` Greg KH
2008-11-06 16:41 ` H L
2008-11-06 16:49 ` Greg KH
2008-11-06 17:38 ` Fischer, Anna
2008-11-06 18:03 ` Greg KH
2008-11-06 20:04 ` Fischer, Anna
2008-11-09 12:44 ` Avi Kivity
2008-11-09 19:25 ` Greg KH
2008-11-09 19:37 ` Avi Kivity
2008-11-11 6:08 ` Greg KH
2008-11-11 9:00 ` Avi Kivity
2008-11-06 18:36 ` Matthew Wilcox
2008-11-06 22:38 ` Anthony Liguori
2008-11-06 22:58 ` Matthew Wilcox
2008-11-07 6:19 ` Greg KH
2008-11-07 15:17 ` Yu Zhao
2008-11-07 18:48 ` Greg KH
2008-11-08 11:09 ` Fischer, Anna
2008-11-08 15:37 ` Leonid Grossman
2008-11-13 7:49 ` Yu Zhao
2008-11-09 12:47 ` Avi Kivity
2008-11-07 1:52 ` Dong, Eddie
2008-11-07 2:08 ` Nakajima, Jun
2008-11-07 15:21 ` Andi Kleen
2008-11-09 12:53 ` Avi Kivity
2008-11-07 16:01 ` Yu Zhao
[not found] ` <87d4h7pnnm.fsf__4937.77150190926$1226071173$gmane$org@basil.nowhere.org>
2008-11-12 22:41 ` Anthony Liguori
2008-11-16 16:04 ` Avi Kivity
2008-11-17 1:46 ` Zhao, Yu
2008-11-06 17:47 ` Matthew Wilcox
2008-11-06 17:53 ` Greg KH
2008-11-06 22:24 ` Simon Horman
2008-11-06 22:40 ` Anthony Liguori
2008-11-07 6:17 ` Greg KH
2008-11-07 7:47 ` Zhao, Yu
[not found] ` <200811111048.45242.rusty@rustcorp.com.au>
2008-11-17 12:01 ` Yu Zhao
2008-11-09 12:58 ` Avi Kivity
2008-11-09 6:41 ` Muli Ben-Yehuda
2008-11-09 13:03 ` Avi Kivity
2008-11-06 23:54 ` Chris Wright
2008-11-07 6:10 ` Greg KH
2008-11-07 7:06 ` Zhao, Yu
2008-11-07 7:29 ` Leonid Grossman
2008-11-06 18:05 ` H L
2008-11-06 18:24 ` Greg KH
2008-11-06 21:35 ` Fischer, Anna
2008-11-07 6:18 ` Greg KH
2008-11-07 6:03 ` Zhao, Yu
2008-11-06 16:51 ` git repository for SR-IOV development? H L
2008-11-06 16:59 ` Greg KH
2008-11-06 19:58 ` H L
2008-11-06 22:56 ` Simon Horman
2008-11-07 1:58 ` Greg KH
2008-11-07 13:09 ` Yu Zhao
2008-11-07 5:18 ` [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Zhao, Yu
2008-11-07 6:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022084148.GE3773@yzhao12-linux.sh.intel.com \
--to=yu.zhao@intel.com \
--cc=achiang@hp.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome