mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
	Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	Ingo Molnar <mingo@elte.hu>,
	ltt-dev@lists.casi.polymtl.ca,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [ltt-dev] [PATCH] Poll : introduce poll_wait_exclusive() new function
Date: Tue,  2 Dec 2008 13:44:51 +0900 (JST)	[thread overview]
Message-ID: <20081202134241.1CF4.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0812011711280.27086@alien.or.mcafeemobile.com>

> > Any thought ?
> 
> That looks fine, but before waving the Thundering Herd flag some 
> performance numbers should be given IMO, considerng also that this is a 
> rather particular use of the poll subsystem.
> Eventually, isn't something like the patch below better than adding custom 
> case names to poll_wait() ALA poll_wait_LONGNAMESFOLLOW()?
> That way you can pass your own queueing function:
> 
> 	poll_wait_qfunc(file, head, pt, add_wait_queue_exclusive);

make sense.
I don't found any bug in your patch.

	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


Thanks.



      reply	other threads:[~2008-12-02  4:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 11:24 [RFC PATCH] Poll : add poll_wait_set_exclusive (fixing thundering herd problem in LTTng) Mathieu Desnoyers
2008-11-24 11:44 ` [ltt-dev] " KOSAKI Motohiro
2008-11-24 11:51   ` Mathieu Desnoyers
2008-11-24 12:11     ` KOSAKI Motohiro
2008-11-24 12:16       ` Mathieu Desnoyers
2008-11-25 10:50         ` [PATCH] Poll : introduce poll_wait_exclusive() new function KOSAKI Motohiro
2008-11-25 21:19           ` Davide Libenzi
2008-11-26  1:09             ` KOSAKI Motohiro
2008-11-26 11:15             ` [ltt-dev] " Mathieu Desnoyers
2008-11-26 11:20               ` Andrew McDermott
2008-11-26 22:27                 ` Mathieu Desnoyers
2008-11-27  0:08               ` Davide Libenzi
2008-11-27 12:50                 ` KOSAKI Motohiro
2008-11-28 13:13                 ` Mathieu Desnoyers
2008-12-02  1:27                   ` Davide Libenzi
2008-12-02  4:44                     ` KOSAKI Motohiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081202134241.1CF4.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=compudj@krystal.dyndns.org \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®