mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davide Libenzi <davidel@xmailserver.org>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Ingo Molnar <mingo@elte.hu>,
	ltt-dev@lists.casi.polymtl.ca,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [ltt-dev] [PATCH] Poll : introduce poll_wait_exclusive() new function
Date: Wed, 26 Nov 2008 16:08:11 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.1.10.0811261559180.11771@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <20081126111511.GE14826@Krystal>

On Wed, 26 Nov 2008, Mathieu Desnoyers wrote:

> One of the key design rule of LTTng is to do not depend on such
> system-wide data structures, or entity (e.g. single manager thread).
> Everything is per-cpu, and it does scale very well.
> 
> I wonder how badly the approach you propose can scale on large NUMA
> systems, where having to synchronize everything through a single thread
> might become an important point of contention, just due to the cacheline
> bouncing and extra scheduler activity involved.

I dunno the LTT architecture, so I'm staying out of that discussion.
But, if the patch you're trying to push is to avoid thundering herd of so 
many threads waiting on the single file*, you've got the same problem 
right there. You've got at least the spinlock protecting the queue 
where these threads are focusing, whose cacheline is bounced gets bounced 
all over the CPUs.
Do you have any measure of the improvements that such poll_wait_exclusive()
will eventually lead to?



- Davide



  parent reply	other threads:[~2008-11-27  0:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 11:24 [RFC PATCH] Poll : add poll_wait_set_exclusive (fixing thundering herd problem in LTTng) Mathieu Desnoyers
2008-11-24 11:44 ` [ltt-dev] " KOSAKI Motohiro
2008-11-24 11:51   ` Mathieu Desnoyers
2008-11-24 12:11     ` KOSAKI Motohiro
2008-11-24 12:16       ` Mathieu Desnoyers
2008-11-25 10:50         ` [PATCH] Poll : introduce poll_wait_exclusive() new function KOSAKI Motohiro
2008-11-25 21:19           ` Davide Libenzi
2008-11-26  1:09             ` KOSAKI Motohiro
2008-11-26 11:15             ` [ltt-dev] " Mathieu Desnoyers
2008-11-26 11:20               ` Andrew McDermott
2008-11-26 22:27                 ` Mathieu Desnoyers
2008-11-27  0:08               ` Davide Libenzi [this message]
2008-11-27 12:50                 ` KOSAKI Motohiro
2008-11-28 13:13                 ` Mathieu Desnoyers
2008-12-02  1:27                   ` Davide Libenzi
2008-12-02  4:44                     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0811261559180.11771@alien.or.mcafeemobile.com \
    --to=davidel@xmailserver.org \
    --cc=compudj@krystal.dyndns.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®