mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyle McMartin <kyle@infradead.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Kyle McMartin <kyle@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Bartelmus <lirc@bartelmus.de>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] make checkpatch warn about access to current->comm
Date: Tue, 27 Jan 2009 01:09:43 -0500	[thread overview]
Message-ID: <20090127060943.GD5034@bombadil.infradead.org> (raw)
In-Reply-To: <20090128145534.D46A.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Tue, Jan 27, 2009 at 02:58:51PM +0900, KOSAKI Motohiro wrote:
> > On Tue, Jan 27, 2009 at 02:50:18PM +0900, KOSAKI Motohiro wrote:
> > > I think "char tcomm[sizeof(current->comm)];" is valid code.
> > > if checkpatch.pl don't warn "sizeof(current->comm)", I'm glad.
> > 
> > Awfully interesting way of writing TASK_COMM_LEN :)
> 
> I don't think so awfully.
> I think "sizeof(array_val)" is typical code in kernel.
> 
> I agree that we can rewrite s/tcomm[sizeof(current->comm)]/char tcomm[TASK_COMM_LEN]/.
> but it's annoyed.
> 

If current->comm was changed to be kmalloc'd this would need to be
changed anyway, so why not just do it now?

regards, Kyle

  reply	other threads:[~2009-01-27  6:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 19:32 get_task_comm() not exported? Christoph Bartelmus
2009-01-18 22:36 ` KOSAKI Motohiro
2009-01-20 21:24   ` Christoph Bartelmus
2009-01-27  5:09     ` [PATCH] export get_task_comm() KOSAKI Motohiro
2009-01-27  5:16       ` Andrew Morton
2009-01-27  5:19         ` Kyle McMartin
2009-01-27  5:26           ` Andrew Morton
2009-01-27  5:29             ` Andrew Morton
2009-01-27  5:39               ` [PATCH] make checkpatch warn about access to current->comm Kyle McMartin
2009-01-27  5:50                 ` KOSAKI Motohiro
2009-01-27  5:52                   ` Kyle McMartin
2009-01-27  5:58                     ` KOSAKI Motohiro
2009-01-27  6:09                       ` Kyle McMartin [this message]
2009-01-27 15:45                 ` Linus Torvalds
2009-01-27 15:57                   ` Kyle McMartin
2009-01-27 18:15                   ` Christoph Bartelmus
2009-01-27  8:49               ` [PATCH] export get_task_comm() Alexey Dobriyan
2009-01-27  9:00                 ` Andrew Morton
2009-01-27 10:15                   ` KOSAKI Motohiro
2009-01-27 15:41         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090127060943.GD5034@bombadil.infradead.org \
    --to=kyle@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirc@bartelmus.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®