From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Bartelmus <lirc@bartelmus.de>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] make checkpatch warn about access to current->comm
Date: Tue, 27 Jan 2009 14:50:18 +0900 (JST) [thread overview]
Message-ID: <20090128144316.D467.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20090127053920.GB5034@bombadil.infradead.org>
> +# direct access to current task name is racy, suggest accessor instead.
> + if ($line =~ /current\-\>comm/) {
> + WARN("direct access to current->comm is racy, use get_task_comm() instead.\n" . $herecurr);
> + }
> +
> # use of NR_CPUS is usually wrong
> # ignore definitions of NR_CPUS and usage to define arrays as likely right
> if ($line =~ /\bNR_CPUS\b/ &&
./scripts/checkpatch --file fs/exec.c
------------------------------------------------------
WARNING: direct access to current->comm is racy, use get_task_comm() instead.
#952: FILE: exec.c:952:
+ char tcomm[sizeof(current->comm)];
(snip)
WARNING: direct access to current->comm is racy, use get_task_comm() instead.
#1459: FILE: exec.c:1459:
+ "%s", current->comm);
(snip)
WARNING: direct access to current->comm is racy, use get_task_comm() instead.
#1788: FILE: exec.c:1788:
+ if (!strcmp(delimit, current->comm)) {
---------------------------
I think "char tcomm[sizeof(current->comm)];" is valid code.
if checkpatch.pl don't warn "sizeof(current->comm)", I'm glad.
next prev parent reply other threads:[~2009-01-27 5:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 19:32 get_task_comm() not exported? Christoph Bartelmus
2009-01-18 22:36 ` KOSAKI Motohiro
2009-01-20 21:24 ` Christoph Bartelmus
2009-01-27 5:09 ` [PATCH] export get_task_comm() KOSAKI Motohiro
2009-01-27 5:16 ` Andrew Morton
2009-01-27 5:19 ` Kyle McMartin
2009-01-27 5:26 ` Andrew Morton
2009-01-27 5:29 ` Andrew Morton
2009-01-27 5:39 ` [PATCH] make checkpatch warn about access to current->comm Kyle McMartin
2009-01-27 5:50 ` KOSAKI Motohiro [this message]
2009-01-27 5:52 ` Kyle McMartin
2009-01-27 5:58 ` KOSAKI Motohiro
2009-01-27 6:09 ` Kyle McMartin
2009-01-27 15:45 ` Linus Torvalds
2009-01-27 15:57 ` Kyle McMartin
2009-01-27 18:15 ` Christoph Bartelmus
2009-01-27 8:49 ` [PATCH] export get_task_comm() Alexey Dobriyan
2009-01-27 9:00 ` Andrew Morton
2009-01-27 10:15 ` KOSAKI Motohiro
2009-01-27 15:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128144316.D467.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirc@bartelmus.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®